| commit | 042dbf83122b14fd1dd32705c8f8b7d65c22f21b | [log] |
|---|---|---|
| author | Eike Rathke <erack@redhat.com> | Thu Mar 25 12:04:22 2021 +0100 |
| committer | Eike Rathke <erack@redhat.com> | Thu Mar 25 16:31:29 2021 +0100 |
| tree | aa3aa08a84ffee45a95293f2a9fa3a0a1c983c25 | |
| parent | c8c5a06eed6c22e40bda9787ace5467d551130b6 [diff] |
Resolves: tdf#141146 Fix LOOKUP in array with result scalar / single reference The returns are identical to the cell range search. Also, the single reference case is just a special case of range reference and acts as row vector (as number of rows is not greater than number of columns), equally extending the passed "range" if found position is greater than 1. Extending a result range such leads to the result cell not being listened to and not acting on its changes, this was always the case for results of an extended range, and Excel seems to have the same problem. This is logical because the range cell is unknown in advance, and certainly we don't want to make LOOKUP() a volatile function being executed on each change everywhere. Solutions to this could be: - create a single cell broadcaster/listener on the fly while pushing the out-of-band cell result - this is nasty and modifying the model while interpreting is ugly and error prone and it's unclear who should destroy such broadcaster if the query or data range/array changed - so this is a no-go - create a range broadcaster/listener for the entire row right of the cell - would mean to inspect during listener setup to which parameter of which OpCode a reference belongs - really? ...no - which also doesn't help if a given range is too short and is extended - would mean to always extend the listener either as row or column * doubtable if it is really worth it for this one time off fouled up Excel behaviour * or should we rather return an error for out-of-band results? - but then again for ranges it always worked this like + do not advertise, or strongly deprecate such use + a result range should have the same length as the search range/array Change-Id: Ie903f4491844306d3768ee40bd16786ebe648461 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113085 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.
A quick overview of the LibreOffice code structure.
You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.
The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.
These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:
If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.
You can find the TDF configure switches in the distro-configs/ directory.
To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.
For more information see the build instructions for your platform in the TDF wiki.
Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:
However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:
| Module | Description |
|---|---|
| sal/ | this provides a simple System Abstraction Layer |
| tools/ | this provides basic internal types: 'Rectangle', 'Color' etc. |
| vcl/ | this is the widget toolkit library and one rendering abstraction |
| framework | UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files |
| sfx2/ | legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc. |
| svx/ | drawing model related helper code, including much of Draw/Impress |
Then applications
| Module | Description |
|---|---|
| desktop/ | this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop |
| sw/ | Writer |
| sc/ | Calc |
| sd/ | Draw / Impress |
There are several other libraries that are helpful from a graphical perspective:
| Module | Description |
|---|---|
| basegfx/ | algorithms and data-types for graphics as used in the canvas |
| canvas/ | new (UNO) canvas rendering model with various backends |
| cppcanvas/ | C++ helper classes for using the UNO canvas |
| drawinglayer/ | View code to render drawable objects and break them down into primitives we can render more easily. |
Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)
The UNO API include files should consistently use double quotes, for the benefit of external users of this API.
loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.
Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.