tdf#43257 SVG: Id value can contain other characters than alphanumerics

Ie: "graph-1", "graph_1", "graph.1", etc...

Besides, modify !( str_p("'") | str_p("\"") ) condition as the 'fill' attribute  can be defined as fill="url('#graph1')" but not as fill="url("#graph1")"

Change-Id: I7fb2c5b61487214ab02b207ad64d29bb2a1e107a
Reviewed-on: https://gerrit.libreoffice.org/19961
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
1 file changed
tree: d6674c169039c6634b0f58d88b40fb2b8e62efb2
  1. .git-hooks/
  2. accessibility/
  3. android/
  4. animations/
  5. apple_remote/
  6. avmedia/
  7. basctl/
  8. basebmp/
  9. basegfx/
  10. basic/
  11. bean/
  12. bin/
  13. binaryurp/
  14. bridges/
  15. canvas/
  16. chart2/
  17. clew/
  18. cli_ure/
  19. codemaker/
  20. comphelper/
  21. compilerplugins/
  22. config_host/
  23. configmgr/
  24. connectivity/
  25. cppcanvas/
  26. cppu/
  27. cppuhelper/
  28. cpputools/
  29. cui/
  30. dbaccess/
  31. desktop/
  32. distro-configs/
  33. drawinglayer/
  34. dtrans/
  35. editeng/
  36. embeddedobj/
  37. embedserv/
  38. eventattacher/
  39. extensions/
  40. external/
  41. extras/
  42. filter/
  43. forms/
  44. formula/
  45. fpicker/
  46. framework/
  47. helpcompiler/
  48. hwpfilter/
  49. i18nlangtag/
  50. i18npool/
  51. i18nutil/
  52. icon-themes/
  53. idl/
  54. idlc/
  55. include/
  56. instsetoo_native/
  57. io/
  58. ios/
  59. javaunohelper/
  60. jurt/
  61. jvmaccess/
  62. jvmfwk/
  63. l10ntools/
  64. librelogo/
  65. libreofficekit/
  66. lingucomponent/
  67. linguistic/
  68. lotuswordpro/
  69. m4/
  70. mysqlc/
  71. nlpsolver/
  72. o3tl/
  73. odk/
  74. offapi/
  75. officecfg/
  76. onlineupdate/
  77. oovbaapi/
  78. oox/
  79. opencl/
  80. osx/
  81. package/
  82. postprocess/
  83. pyuno/
  84. qadevOOo/
  85. readlicense_oo/
  86. registry/
  87. remotebridges/
  88. reportbuilder/
  89. reportdesign/
  90. ridljar/
  91. rsc/
  92. sal/
  93. salhelper/
  94. sax/
  95. sc/
  96. scaddins/
  97. sccomp/
  98. scp2/
  99. scripting/
  100. sd/
  101. sdext/
  102. setup_native/
  103. sfx2/
  104. shell/
  105. slideshow/
  106. smoketest/
  107. solenv/
  108. soltools/
  109. sot/
  110. starmath/
  111. stoc/
  112. store/
  113. svgio/
  114. svl/
  115. svtools/
  116. svx/
  117. sw/
  118. swext/
  119. sysui/
  120. test/
  121. testtools/
  122. toolkit/
  123. tools/
  124. tubes/
  125. ucb/
  126. ucbhelper/
  127. udkapi/
  128. UnoControls/
  129. unodevtools/
  130. unoidl/
  131. unoil/
  132. unotest/
  133. unotools/
  134. unoxml/
  135. ure/
  136. uui/
  137. vbahelper/
  138. vcl/
  139. winaccessibility/
  140. windows/
  141. wizards/
  142. writerfilter/
  143. writerperfect/
  144. xmerge/
  145. xmlhelp/
  146. xmloff/
  147. xmlreader/
  148. xmlscript/
  149. xmlsecurity/
  150. .gitattributes
  151. .gitignore
  152. .gitmodules
  153. .gitreview
  154. autogen.sh
  155. config.guess
  156. config.sub
  157. config_host.mk.in
  158. config_host_lang.mk.in
  159. configure.ac
  160. COPYING
  161. COPYING.LGPL
  162. COPYING.MPL
  163. download.lst
  164. g
  165. install-sh
  166. leak-suppress.txt
  167. Library_merged.mk
  168. lo.xcent.in
  169. logerrit
  170. Makefile.fetch
  171. Makefile.gbuild
  172. Makefile.in
  173. README.cross
  174. README.md
  175. README.Solaris
  176. Repository.mk
  177. RepositoryExternal.mk
  178. RepositoryFixes.mk
  179. RepositoryModule_build.mk
  180. RepositoryModule_host.mk
  181. sanitize-ubsan-blacklist
  182. TEMPLATE.SOURCECODE.HEADER
  183. unusedcode.easy
  184. unusedcode.exclude
  185. unusedcode.README
README.md

LibreOffice

Coverity Scan Build Status

A quick overview of the LibreOffice code structure.

Overview

You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.

The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.

The important bits of code

Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:

http://docs.libreoffice.org/

However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:

ModuleDescription
sal/this provides a simple System Abstraction Layer
tools/this provides basic internal types: 'Rectangle', 'Color' etc.
vcl/this is the widget toolkit library and one rendering abstraction
frameworkUNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files
sfx2/legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc.
svx/drawing model related helper code, including much of Draw/Impress

Then applications

ModuleDescription
desktop/this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop
sw/Writer
sc/Calc
sd/Draw / Impress

There are several other libraries that are helpful from a graphical perspective:

ModuleDescription
basebmp/enables a VCL compatible rendering API to render to bitmaps, as used for LibreOffice Online, Android, iOS, etc.
basegfx/algorithms and data-types for graphics as used in the canvas
canvas/new (UNO) canvas rendering model with various backends
cppcanvas/C++ helper classes for using the UNO canvas
drawinglayer/View code to render drawable objects and break them down into primitives we can render more easily.

Finding out more

Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.