Related: tdf#125035 Include day of week in formatindex="19" DATE_SYSTEM_LONG

Used programmatically with number formatter's NF_DATE_SYSTEM_LONG
but quite some locales were lacking the day of week; maybe legacy
because duplicated formats sometimes were avoided, which nowadays
are suppressed in the number format dialog. Made the format code a
copy of formatindex="30" explicit DATE_SYS_NNNNDMMMMYYYY.

Didn't know what to do about lt_LT so kept that as is.

This made it necessary to adapt a dreaded UITest_writer_tests5
test that checks for listbox content,
test_date_field_with_custom_format, which depends on actual locale
data. See comment there.

Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118335
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
(cherry picked from commit 56ae948b08010ed1b61be9857c8c6ae4e97e86b2)

 Conflicts:
	sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py

Change-Id: Ifc26a4a5be6bed3fb8d9cedc1afcba1225751635
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118389
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
diff --git a/i18npool/source/localedata/data/da_DK.xml b/i18npool/source/localedata/data/da_DK.xml
index 540e2ca..6b659a0 100644
--- a/i18npool/source/localedata/data/da_DK.xml
+++ b/i18npool/source/localedata/data/da_DK.xml
@@ -108,7 +108,7 @@
      <FormatCode>DD-MM-YY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>D. MMMM YYYY</FormatCode>
      <FormatCode>NNNND. MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="medium" usage="DATE" formatindex="20">
      <FormatCode>DD-MM-YY</FormatCode>
diff --git a/i18npool/source/localedata/data/en_CA.xml b/i18npool/source/localedata/data/en_CA.xml
index 9e637a7..d3eb880 100644
--- a/i18npool/source/localedata/data/en_CA.xml
+++ b/i18npool/source/localedata/data/en_CA.xml
@@ -116,7 +116,7 @@
      <FormatCode>YY-M-D</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>MMMM D, YYYY</FormatCode>
      <FormatCode>NNNNMMMM D, YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="false" type="medium" usage="DATE" formatindex="20">
      <FormatCode>YY-MM-DD</FormatCode>
diff --git a/i18npool/source/localedata/data/en_DK.xml b/i18npool/source/localedata/data/en_DK.xml
index f8ac52e..041ce09 100644
--- a/i18npool/source/localedata/data/en_DK.xml
+++ b/i18npool/source/localedata/data/en_DK.xml
@@ -120,7 +120,7 @@
      <FormatCode>YY-MM-DD</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>DD MMMM YYYY</FormatCode>
      <FormatCode>NNNND. MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="false" type="medium" usage="DATE" formatindex="20">
      <FormatCode>YY-MM-DD</FormatCode>
diff --git a/i18npool/source/localedata/data/en_GB.xml b/i18npool/source/localedata/data/en_GB.xml
index 2928b62..ac82153 100644
--- a/i18npool/source/localedata/data/en_GB.xml
+++ b/i18npool/source/localedata/data/en_GB.xml
@@ -79,7 +79,7 @@
      <FormatCode>DD/MM/YY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>DD MMMM YYYY</FormatCode>
      <FormatCode>NNNND MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey10" default="false" type="long" usage="DATE" formatindex="22">
      <FormatCode>D MMM YY</FormatCode>
diff --git a/i18npool/source/localedata/data/en_GH.xml b/i18npool/source/localedata/data/en_GH.xml
index ccda3d2..0a6ea83 100644
--- a/i18npool/source/localedata/data/en_GH.xml
+++ b/i18npool/source/localedata/data/en_GH.xml
@@ -114,7 +114,7 @@
      <FormatCode>YY/MM/DD</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>DD MMMM YYYY</FormatCode>
      <FormatCode>NNNND MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="medium" usage="DATE" formatindex="20">
      <FormatCode>YY/MM/DD</FormatCode>
diff --git a/i18npool/source/localedata/data/en_NA.xml b/i18npool/source/localedata/data/en_NA.xml
index 4322f2b..09d481e 100644
--- a/i18npool/source/localedata/data/en_NA.xml
+++ b/i18npool/source/localedata/data/en_NA.xml
@@ -114,7 +114,7 @@
      <FormatCode>YY/MM/DD</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>DD MMMM YYYY</FormatCode>
      <FormatCode>NNNND MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="medium" usage="DATE" formatindex="20">
      <FormatCode>YY/MM/DD</FormatCode>
diff --git a/i18npool/source/localedata/data/en_ZA.xml b/i18npool/source/localedata/data/en_ZA.xml
index ec3990a..574f1da 100644
--- a/i18npool/source/localedata/data/en_ZA.xml
+++ b/i18npool/source/localedata/data/en_ZA.xml
@@ -116,7 +116,7 @@
      <FormatCode>YY-MM-DD</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>DD MMMM YYYY</FormatCode>
      <FormatCode>NNNND MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="false" type="medium" usage="DATE" formatindex="20">
      <FormatCode>YY-MM-DD</FormatCode>
diff --git a/i18npool/source/localedata/data/eo.xml b/i18npool/source/localedata/data/eo.xml
index 4fb04f9..4d01253 100644
--- a/i18npool/source/localedata/data/eo.xml
+++ b/i18npool/source/localedata/data/eo.xml
@@ -78,7 +78,7 @@
      <FormatCode>YY-MM-DD</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>D MMMM YYYY</FormatCode>
      <FormatCode>NNNND MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey10" default="false" type="long" usage="DATE" formatindex="22">
      <FormatCode>D MMM YY</FormatCode>
diff --git a/i18npool/source/localedata/data/fi_FI.xml b/i18npool/source/localedata/data/fi_FI.xml
index cace5bc..c800db1 100644
--- a/i18npool/source/localedata/data/fi_FI.xml
+++ b/i18npool/source/localedata/data/fi_FI.xml
@@ -108,7 +108,7 @@
      <FormatCode>P.K.VVVV</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>P. KKKK VVVV</FormatCode>
      <FormatCode>NNNNP. KKKK VVVV</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="medium" usage="DATE" formatindex="20">
      <FormatCode>PP.KK.VV</FormatCode>
diff --git a/i18npool/source/localedata/data/fo_FO.xml b/i18npool/source/localedata/data/fo_FO.xml
index 3b43a6a..0532832 100644
--- a/i18npool/source/localedata/data/fo_FO.xml
+++ b/i18npool/source/localedata/data/fo_FO.xml
@@ -78,7 +78,7 @@
      <FormatCode>DD-MM-YY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>D. MMMM YYYY</FormatCode>
      <FormatCode>NNNND. MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey10" default="false" type="long" usage="DATE" formatindex="22">
      <FormatCode>D. MMM YY</FormatCode>
diff --git a/i18npool/source/localedata/data/fr_CA.xml b/i18npool/source/localedata/data/fr_CA.xml
index 25e81ab..fd8bd9c 100644
--- a/i18npool/source/localedata/data/fr_CA.xml
+++ b/i18npool/source/localedata/data/fr_CA.xml
@@ -110,7 +110,7 @@
      <FormatCode>AA-M-J</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>J MMMM AAAA</FormatCode>
      <FormatCode>NNNNJ MMMM AAAA</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="false" type="medium" usage="DATE" formatindex="20">
      <FormatCode>AA-MM-JJ</FormatCode>
diff --git a/i18npool/source/localedata/data/gd_GB.xml b/i18npool/source/localedata/data/gd_GB.xml
index 13c07a0..476b7dc 100644
--- a/i18npool/source/localedata/data/gd_GB.xml
+++ b/i18npool/source/localedata/data/gd_GB.xml
@@ -137,7 +137,7 @@
      <FormatCode>DD/MM/YY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>DD MMMM YYYY</FormatCode>
      <FormatCode>NNNND MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey10" default="false" type="long" usage="DATE" formatindex="22">
      <FormatCode>D MMM YY</FormatCode>
diff --git a/i18npool/source/localedata/data/hu_HU.xml b/i18npool/source/localedata/data/hu_HU.xml
index 35b2a9cf..4c9445a 100644
--- a/i18npool/source/localedata/data/hu_HU.xml
+++ b/i18npool/source/localedata/data/hu_HU.xml
@@ -114,7 +114,7 @@
      <FormatCode>YYYY". "MM". "DD.</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>YYYY". "MMMM D.</FormatCode>
      <FormatCode>YYYY". "MMMM D., NNN</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="false" type="medium" usage="DATE" formatindex="20">
      <FormatCode>YY.MM.DD.</FormatCode>
diff --git a/i18npool/source/localedata/data/id_ID.xml b/i18npool/source/localedata/data/id_ID.xml
index e4024cb..45cc97e 100644
--- a/i18npool/source/localedata/data/id_ID.xml
+++ b/i18npool/source/localedata/data/id_ID.xml
@@ -108,7 +108,7 @@
      <FormatCode>DD/MM/YY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>DD MMMM YYYY</FormatCode>
      <FormatCode>NNNND MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="medium" usage="DATE" formatindex="20">
      <FormatCode>DD/MM/YY</FormatCode>
diff --git a/i18npool/source/localedata/data/is_IS.xml b/i18npool/source/localedata/data/is_IS.xml
index 301799d..c294114 100644
--- a/i18npool/source/localedata/data/is_IS.xml
+++ b/i18npool/source/localedata/data/is_IS.xml
@@ -94,7 +94,7 @@
      <FormatCode>D.MM.YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>D. MMMM, YYYY</FormatCode>
      <FormatCode>NNNND. MMMM, YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="medium" usage="DATE" formatindex="20">
      <FormatCode>DD.MM.YY</FormatCode>
diff --git a/i18npool/source/localedata/data/kl_GL.xml b/i18npool/source/localedata/data/kl_GL.xml
index 4789e09..f5af7ce 100644
--- a/i18npool/source/localedata/data/kl_GL.xml
+++ b/i18npool/source/localedata/data/kl_GL.xml
@@ -108,7 +108,7 @@
      <FormatCode>DD-MM-YY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>D. MMMM YYYY</FormatCode>
      <FormatCode>NNNND. MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="medium" usage="DATE" formatindex="20">
      <FormatCode>DD-MM-YY</FormatCode>
diff --git a/i18npool/source/localedata/data/lg_UG.xml b/i18npool/source/localedata/data/lg_UG.xml
index 9108f92..5c12eb8 100644
--- a/i18npool/source/localedata/data/lg_UG.xml
+++ b/i18npool/source/localedata/data/lg_UG.xml
@@ -108,7 +108,7 @@
      <FormatCode>YY/MM/DD</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>DD MMMM YYYY</FormatCode>
      <FormatCode>NNNND MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="medium" usage="DATE" formatindex="20">
      <FormatCode>YY/MM/DD</FormatCode>
diff --git a/i18npool/source/localedata/data/sv_FI.xml b/i18npool/source/localedata/data/sv_FI.xml
index 953bded..894df6a 100644
--- a/i18npool/source/localedata/data/sv_FI.xml
+++ b/i18npool/source/localedata/data/sv_FI.xml
@@ -108,7 +108,7 @@
      <FormatCode>D.M.YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>D. MMMM YYYY</FormatCode>
      <FormatCode>NNNND. MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="medium" usage="DATE" formatindex="20">
      <FormatCode>DD.MM.YY</FormatCode>
diff --git a/i18npool/source/localedata/data/sv_SE.xml b/i18npool/source/localedata/data/sv_SE.xml
index 51cea45..4a85f9d 100644
--- a/i18npool/source/localedata/data/sv_SE.xml
+++ b/i18npool/source/localedata/data/sv_SE.xml
@@ -109,7 +109,7 @@
      <FormatCode>YYYY-MM-DD</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey9" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>D MMMM YYYY</FormatCode>
      <FormatCode>NNNND MMMM YYYY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey8" default="true" type="short" usage="DATE" formatindex="20">
      <FormatCode>YY-MM-DD</FormatCode>
diff --git a/i18npool/source/localedata/data/zh_HK.xml b/i18npool/source/localedata/data/zh_HK.xml
index 9b18302..df1c52c 100644
--- a/i18npool/source/localedata/data/zh_HK.xml
+++ b/i18npool/source/localedata/data/zh_HK.xml
@@ -91,7 +91,7 @@
      <FormatCode>DD/MM/YY</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey2" default="true" type="long" usage="DATE" formatindex="19">
      <FormatCode>YYYY"年"M"月"D"日"</FormatCode>
      <FormatCode>YYYY"年"M"月"D"日" NNNN</FormatCode>
    </FormatElement>
    <FormatElement msgid="DateFormatskey4" default="false" type="medium" usage="DATE" formatindex="20">
      <FormatCode>YY"年"M"月"D"日"</FormatCode>
diff --git a/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py b/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
index 0d110d3..3670a7d 100644
--- a/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
+++ b/sw/qa/uitest/writer_tests5/DateFormFieldPropertiesDialog.py
@@ -56,8 +56,15 @@ class dateFormFieldDialog(UITestCase):
        itemsList = xDialog.getChild("date_formats_treeview")

        # check whether we have the right format selected
        self.assertEqual(get_state_as_dict(itemsList)["Children"], "20")
        self.assertEqual(get_state_as_dict(itemsList)["SelectEntryText"], "1999. december 31., péntek")
        # This is awkward though because checking for a fixed number of
        # entries if the selected default format happens to equal a
        # standard system format the entry gets duplicated with
        # "[System]" appended. So this may be either 20 or 21 ... and
        # in that case it is the selected format and the
        # SelectEntryText doesn't match the sample string, so all this
        # is rather fragile depending on actual locale data.
        self.assertEqual(get_state_as_dict(itemsList)["Children"], "21")
        self.assertEqual(get_state_as_dict(itemsList)["SelectEntryText"], "1999. december 31., péntek[System]")

        xOKBtn = xDialog.getChild("ok")
        self.ui_test.close_dialog_through_button(xOKBtn)