commit 23a5be4d6d04944dcbbb06912c434eedd3719b3b
author Michael Weghorn <m.weghorn@posteo.de> Mon Jul 01 11:21:23 2024 +0200
committer Michael Weghorn <m.weghorn@posteo.de> Tue Jul 02 09:56:57 2024 +0200
tree be1df169015762fd162a9e54b248d1b4721bb19d
parent 7153b25d4da845bfb309c75df48f9ea00ec70c47

tdf#161853 vcl: Drop SvxIconChoiceCtrl_Impl::HideDDIcon

It's superfluous, as the only place calling it already calls
`pView->PaintImmediately();` manually right after that, which
is the same that `SvxIconChoiceCtrl_Impl::HideDDIcon` does.

Change-Id: I8bf6e27e598fc5070dd551e3152dcc4cad91f1f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169792
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins

vcl/source/control/imivctl.hxx

diff --git a/vcl/source/control/imivctl.hxx b/vcl/source/control/imivctl.hxx
index c290684..f79e010 100644
--- a/vcl/source/control/imivctl.hxx
+++ b/vcl/source/control/imivctl.hxx
@@ -357,8 +357,6 @@ public:
    void                Scroll( tools::Long nDeltaX, tools::Long nDeltaY );
    const Size&         GetItemSize( IcnViewFieldType ) const;

    void                HideDDIcon();

    static bool         IsOver(
                            std::vector<tools::Rectangle>* pSelectedRectList,
                            const tools::Rectangle& rEntryBoundRect

vcl/source/control/imivctl1.cxx

diff --git a/vcl/source/control/imivctl1.cxx b/vcl/source/control/imivctl1.cxx
index a52a863..3b26c6b 100644
--- a/vcl/source/control/imivctl1.cxx
+++ b/vcl/source/control/imivctl1.cxx
@@ -1793,12 +1793,6 @@ void SvxIconChoiceCtrl_Impl::ShowCursor( bool bShow )
    /*pView->*/ShowFocus( aRect );
}


void SvxIconChoiceCtrl_Impl::HideDDIcon()
{
    pView->PaintImmediately();
}

bool SvxIconChoiceCtrl_Impl::HandleScrollCommand( const CommandEvent& rCmd )
{
    tools::Rectangle aDocRect( Point(), aVirtOutputSize );
@@ -1966,7 +1960,6 @@ void SvxIconChoiceCtrl_Impl::MakeVisible( const tools::Rectangle& rRect, bool bS
    aOutputArea.SetPos( aOrigin );
    if( GetUpdateMode() )
    {
        HideDDIcon();
        pView->PaintImmediately();
        ShowCursor( false );
    }