commit 26d191e8ee53a38d350c10d5666c6dd8629c8ab2
author Noel Grandin <noel.grandin@collabora.co.uk> Thu Jun 29 12:55:02 2023 +0200
committer Noel Grandin <noel.grandin@collabora.co.uk> Thu Jun 29 17:45:42 2023 +0200
tree a4890c9561a70e0e4c097c335c2b0cefad7b519a
parent fdfc6eb3fd37f87d51d1836d01259a14a4346a45

m_aMouseClickHdl is dead

It was added in

    commit c706fde1c4ecc6974bcf32ce33aacf3093355ae1
    Resolves: tdf#156067 merge special char dialog/popup logic

But is never assigned a useful value

Change-Id: I476b00a96c53298414239509b2ca5452f0bf08c5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153743
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

include/sfx2/charwin.hxx

diff --git a/include/sfx2/charwin.hxx b/include/sfx2/charwin.hxx
index 515aa64..1e3672a 100644
--- a/include/sfx2/charwin.hxx
+++ b/include/sfx2/charwin.hxx
@@ -83,11 +83,9 @@ class SFX2_DLLPUBLIC SfxCharmapContainer
    std::unique_ptr<weld::Widget> m_xRecentGrid;
    std::unique_ptr<weld::Widget> m_xFavGrid;

    Link<SvxCharView*, void> m_aMouseClickHdl;
    Link<void*, void> m_aUpdateFavHdl;
    Link<void*, void> m_aUpdateRecentHdl;

    DECL_DLLPRIVATE_LINK(CharClickHdl, SvxCharView*, void);
    DECL_DLLPRIVATE_LINK(RecentClearClickHdl, SvxCharView*, void);
    DECL_DLLPRIVATE_LINK(FavClearClickHdl, SvxCharView*, void);
    DECL_DLLPRIVATE_LINK(RecentClearAllClickHdl, SvxCharView*, void);

sfx2/source/control/charmapcontrol.cxx

diff --git a/sfx2/source/control/charmapcontrol.cxx b/sfx2/source/control/charmapcontrol.cxx
index 359b81c..ae3018e 100644
--- a/sfx2/source/control/charmapcontrol.cxx
+++ b/sfx2/source/control/charmapcontrol.cxx
@@ -394,11 +394,6 @@ bool SfxCharmapContainer::isFavChar(std::u16string_view sTitle, std::u16string_v
    return itChar != m_aFavCharList.end() && itFont != m_aFavCharFontList.end();
}

IMPL_LINK(SfxCharmapContainer, CharClickHdl, SvxCharView*, pView, void)
{
    m_aMouseClickHdl.Call(pView);
}

IMPL_LINK(SfxCharmapContainer, RecentClearClickHdl, SvxCharView*, rView, void)
{
    const OUString& sTitle = rView->GetText();