commit 36cb12bce80836a29e5124167b588490b3f7700d
author Eike Rathke <erack@redhat.com> Sat Jun 18 00:56:30 2022 +0200
committer Eike Rathke <erack@redhat.com> Sat Jun 18 11:42:28 2022 +0200
tree 6c933626682de6a3dd60fd54d76fcf2f9e3834ba
parent 1a7913c1b57b333223b30194c67c4d8d11e583d2

Related: tdf#142293 Do not use locale's uppercase for Add-In programmatic name

... so in a tr-TR locale
com.sun.star.sheet.addin.Analysis.getEdate
is not upper-cased to
COM.SUN.STAR.SHEET.ADDİN.ANALYSİS.GETEDATE

Which didn't matter as long as it was consistent and only used for
lookup and mapping, if so..

Additionally, the programmatic name does not need the CharClass
overhead and toAsciiUpperCase() is sufficient and faster.

Change-Id: I1c987cc56dc3a62b5285a0bc367c754e7acb6815
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136070
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins

sc/source/core/tool/addincol.cxx

diff --git a/sc/source/core/tool/addincol.cxx b/sc/source/core/tool/addincol.cxx
index 26b7baa..addb151 100644
--- a/sc/source/core/tool/addincol.cxx
+++ b/sc/source/core/tool/addincol.cxx
@@ -92,7 +92,7 @@ ScUnoAddInFuncData::ScUnoAddInFuncData( const OUString& rNam, const OUString& rL
            pArgDescs[i] = pAD[i];
    }

    aUpperName = ScGlobal::getCharClass().uppercase(aUpperName);
    aUpperName = aUpperName.toAsciiUpperCase();  // programmatic name
    aUpperLocal = ScGlobal::getCharClass().uppercase(aUpperLocal);
}

sc/source/core/tool/interpr4.cxx

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 6f48fb9..03b7869 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -2530,7 +2530,7 @@ void ScInterpreter::ScExternal()
{
    sal_uInt8 nParamCount = GetByte();
    OUString aUnoName;
    OUString aFuncName( ScGlobal::getCharClass().uppercase( pCur->GetExternal() ) );
    OUString aFuncName( pCur->GetExternal().toAsciiUpperCase());    // programmatic name
    LegacyFuncData* pLegacyFuncData = ScGlobal::GetLegacyFuncCollection()->findByName(aFuncName);
    if (pLegacyFuncData)
    {

sc/source/core/tool/parclass.cxx

diff --git a/sc/source/core/tool/parclass.cxx b/sc/source/core/tool/parclass.cxx
index 81c6df1..473177c 100644
--- a/sc/source/core/tool/parclass.cxx
+++ b/sc/source/core/tool/parclass.cxx
@@ -407,7 +407,7 @@ formula::ParamClass ScParameterClassification::GetExternalParameterType( const f
        return eRet;

    // similar to ScInterpreter::ScExternal()
    OUString aFuncName = ScGlobal::getCharClass().uppercase( pToken->GetExternal());
    OUString aFuncName = pToken->GetExternal().toAsciiUpperCase();  // programmatic name
    {
        const LegacyFuncData* pLegacyFuncData = ScGlobal::GetLegacyFuncCollection()->findByName(aFuncName);
        if (pLegacyFuncData)