commit 3dda91dda8764adb3f6cc229236281bb270bba92
author Stephan Bergmann <sbergman@redhat.com> Tue May 30 14:39:23 2017 +0200
committer Stephan Bergmann <sbergman@redhat.com> Tue May 30 14:39:23 2017 +0200
tree 5a593c5b7da9a4382b46af2451c423064b585f36
parent 81318b9a7b1d0f17250b15d6a65c7c04abc59193

Traverse InitListExpr only once

Arbitrarily chosing to traverse the semantic instead of the syntactic form.

Change-Id: Id1b4e49421a5550bb2fa9f0d7e6f83bf7abb6ebb

compilerplugins/clang/redundantcast.cxx

diff --git a/compilerplugins/clang/redundantcast.cxx b/compilerplugins/clang/redundantcast.cxx
index 6a554a7..4ffef35 100644
--- a/compilerplugins/clang/redundantcast.cxx
+++ b/compilerplugins/clang/redundantcast.cxx
@@ -79,6 +79,15 @@ public:
        }
    }

    bool TraverseInitListExpr(
        InitListExpr * expr, DataRecursionQueue * queue = nullptr)
    {
        return WalkUpFromInitListExpr(expr)
            && TraverseSynOrSemInitListExpr(
                expr->isSemanticForm() ? expr : expr->getSemanticForm(),
                queue);
    }

    bool VisitImplicitCastExpr(ImplicitCastExpr const * expr);

    bool VisitCXXStaticCastExpr(CXXStaticCastExpr const * expr);