commit 41b8243464a0aa4730e4c6177f1c4fd6adc260d9
author Patrick Luby <plubius@neooffice.org> Thu Sep 21 20:20:33 2023 -0400
committer Patrick Luby <plubius@neooffice.org> Fri Sep 22 15:51:31 2023 +0200
tree a6e85d6f7693d3ca63bce046f93057f479579b56
parent 0842e6ae7db830b7ccf540685174af101dc68bc0

tdf#157312 Don't change priority

Instances of this class are constructed with
TaskPriority::POST_PAINT, but then it was set to
TaskPriority::HIGHEST when reused. Flushing
seems to be expensive (at least with Skia/Metal) so keep the
existing priority when reused.

Change-Id: Ieb40cd6122f543f76e66456cc92a8643e2320d73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157162
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@neooffice.org>
(cherry picked from commit daa4a29c993df2e137b222ac3e60aa4b417a2d2d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157122

vcl/skia/gdiimpl.cxx

diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index 7145644..2ae3b8d 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -268,7 +268,13 @@ public:
    {
        mpGraphics->performFlush();
        Stop();
        SetPriority(TaskPriority::HIGHEST);
        // tdf#157312 Don't change priority
        // Instances of this class are constructed with
        // TaskPriority::POST_PAINT, but then it was set to
        // TaskPriority::HIGHEST when reused. Flushing
        // seems to be expensive (at least with Skia/Metal) so keep the
        // existing priority when reused.
        SetPriority(TaskPriority::POST_PAINT);
    }
};