commit 439f487d14ce4afaa25b8aa23cf954ae2ddaeb26
author Patrick Luby <plubius@neooffice.org> Thu Sep 21 20:20:33 2023 -0400
committer Noel Grandin <noel.grandin@collabora.co.uk> Wed Sep 27 14:10:40 2023 +0200
tree 58654218558ab088bb5e8f602096d0de88d6c24a
parent f49f87f628197bd58e5a5411a77615a677c0ff83

tdf#157312 Don't change priority

Instances of this class are constructed with
TaskPriority::POST_PAINT, but then it was set to
TaskPriority::HIGHEST when reused. Flushing
seems to be expensive (at least with Skia/Metal) so keep the
existing priority when reused.

Change-Id: Ieb40cd6122f543f76e66456cc92a8643e2320d73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157162
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@neooffice.org>
(cherry picked from commit daa4a29c993df2e137b222ac3e60aa4b417a2d2d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157123
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

vcl/skia/gdiimpl.cxx

diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index dbe64f3..7a24060 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -254,7 +254,13 @@ public:
    {
        mpGraphics->performFlush();
        Stop();
        SetPriority(TaskPriority::HIGHEST);
        // tdf#157312 Don't change priority
        // Instances of this class are constructed with
        // TaskPriority::POST_PAINT, but then it was set to
        // TaskPriority::HIGHEST when reused. Flushing
        // seems to be expensive (at least with Skia/Metal) so keep the
        // existing priority when reused.
        SetPriority(TaskPriority::POST_PAINT);
    }
};