commit 461e9f2ad21046526c6644136f0abda91b0e4798
author Michael Stahl <Michael.Stahl@cib.de> Fri Jun 19 15:05:42 2020 +0200
committer Michael Stahl <michael.stahl@cib.de> Fri Jun 19 19:52:58 2020 +0200
tree 93b05df08c4d554bbb680f3afe3cb6e5bc211b6d
parent ac65ade24aa10c0a39d7d38576ad54bd00724455

tdf#132326 sw_redlinehide: no frames allowed in Undo SwNodesArray

This crashes in SwAccessibleParagraph::GetRealHeadingLevel(); the a11y
should have been disposed earlier because the node it's connected to is
in the Undo SwNodesArray.

When SwUndoDelete::SwUndoDelete() calls SwNodes::MoveNodes(), all
existing frames must be destroyed; the MoveNodes() would reset its flag
temporarily inside a section, to delay creating the frames inside the
section when moving to the live SwNodesArray, but this also prevents
the deletion when moving in the other direction.

(crash is regression from 723728cd358693b8f4bc9d913541aa4479f2bd48)

Change-Id: I13719bf98ea96b8d68db3ee78cf7f4b61a99e7e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96734
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
(cherry picked from commit a60dd9ef1361c5925803acaa5292e99277d1faf3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96700

sw/source/core/docnode/nodes.cxx

diff --git a/sw/source/core/docnode/nodes.cxx b/sw/source/core/docnode/nodes.cxx
index b0a6055..0a72075 100644
--- a/sw/source/core/docnode/nodes.cxx
+++ b/sw/source/core/docnode/nodes.cxx
@@ -661,7 +661,11 @@ bool SwNodes::MoveNodes( const SwNodeRange& aRange, SwNodes & rNodes,
                    {
                        pSctNd->NodesArrChgd();
                        ++nSectNdCnt;
                        bNewFrames = false;
                        // tdf#132326 do not let frames survive in undo nodes
                        if (!GetDoc()->GetIDocumentUndoRedo().IsUndoNodes(rNodes))
                        {
                            bNewFrames = false;
                        }
                    }
                }
            }