commit 4b7b6993134a48c850608c758f7b7283bed27fec
author Noel Grandin <noel.grandin@collabora.co.uk> Wed Dec 18 15:35:53 2019 +0200
committer Noel Grandin <noel.grandin@collabora.co.uk> Wed Dec 18 15:33:08 2019 +0100
tree 8c01c556bc4434f6f649c6bf8d48a2b6c9f1975d
parent 280f54a942ce9fe0177100312fc45a398955bd8a

reduce temporary OUString creation

speeds up dialog load time a little (5%)

Change-Id: Ia4e5f1973bb6f06b2b5ec6a251e4ad07fc3636d2
Reviewed-on: https://gerrit.libreoffice.org/85389
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

svx/source/unodraw/unoprov.cxx

diff --git a/svx/source/unodraw/unoprov.cxx b/svx/source/unodraw/unoprov.cxx
index 8914239..639b8c7 100644
--- a/svx/source/unodraw/unoprov.cxx
+++ b/svx/source/unodraw/unoprov.cxx
@@ -1838,12 +1838,24 @@ static bool SvxUnoConvertResourceStringBuiltIn(const char** pSourceResIds, const

    for(int i = 0; i < nCount; ++i )
    {
        OUString aStrDefName = bToApi ? SvxResId(pSourceResIds[i]) : OUString::createFromAscii(pSourceResIds[i]);
        if( sStr == aStrDefName )
        if (bToApi)
        {
            OUString aReplace = bToApi ? OUString::createFromAscii(pDestResIds[i]) : SvxResId(pDestResIds[i]);
            rString = rString.replaceAt( 0, aStrDefName.getLength(), aReplace );
            return true;
            OUString aStrDefName = SvxResId(pSourceResIds[i]);
            if( sStr == aStrDefName )
            {
                OUString aReplace = OUString::createFromAscii(pDestResIds[i]);
                rString = rString.replaceAt( 0, aStrDefName.getLength(), aReplace );
                return true;
            }
        }
        else
        {
            if( sStr.equalsAscii(pSourceResIds[i]) )
            {
                OUString aReplace = SvxResId(pDestResIds[i]);
                rString = rString.replaceAt( 0, strlen(pSourceResIds[i]), aReplace );
                return true;
            }
        }
    }