commit 4da61d4cc8f70ff62d7bac23a1b97d9d7011a678
author Mike Kaganski <mike.kaganski@collabora.com> Sun Dec 02 01:14:15 2018 +0300
committer Mike Kaganski <mike.kaganski@collabora.com> Sun Dec 02 05:31:19 2018 +0100
tree 46473e2819f4d98a7f82a3a814b1fb521e925373
parent 1f2d3b3f09d16033dae1f99f7739564a5f4c5482

tdf#120703 PVS: logical AND had been used instead of bitwise

V560 A part of conditional expression is always true:
     sal_Int32(0xFF) != 0.

Change-Id: I5f19c4ff20e91767d22a85239f9693d68ff360b1
Reviewed-on: https://gerrit.libreoffice.org/64414
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

canvas/source/simplecanvas/simplecanvasimpl.cxx

diff --git a/canvas/source/simplecanvas/simplecanvasimpl.cxx b/canvas/source/simplecanvas/simplecanvasimpl.cxx
index fe558b0..2e38ee8 100644
--- a/canvas/source/simplecanvas/simplecanvasimpl.cxx
+++ b/canvas/source/simplecanvas/simplecanvasimpl.cxx
@@ -112,7 +112,7 @@
    private:
        bool isStrokingEnabled() const
        {
            return maRenderState.m_aPenColor.getInValue() && sal_Int32(0xFF) != 0;
            return maRenderState.m_aPenColor.getInValue() % 0x100 != 0;
        }

        rendering::RenderState createStrokingRenderState() const
@@ -125,7 +125,7 @@

        bool isFillingEnabled() const
        {
            return maRenderState.m_aFillColor.getInValue() && sal_Int32(0xFF) != 0;
            return maRenderState.m_aFillColor.getInValue() % 0x100 != 0;
        }

        rendering::RenderState createFillingRenderState() const