commit 4e8f01716ec11ea8e7b8991a659e3ef708f4fee4
author Mike Kaganski <mike.kaganski@collabora.com> Mon Nov 26 11:17:01 2018 +0300
committer Mike Kaganski <mike.kaganski@collabora.com> Sat Dec 01 19:08:05 2018 +0100
tree fdbea92b2f8133b0f3644ae987d2ef8d70ba7caa
parent 56d97cdd0af15c90c744d2ac66e879818c073ec6

tdf#120703 PVS: the condition needs &&, not ||

... ever since commit 9ae5a91f7955e44d3b24a3f7741f9bca02ac7f24

V560 A part of conditional expression is always false: nRangeNo < nRCount.
     The value range of unsigned short type: [0, 65535].

Actually, simple if (nRangeNo < nRCount) would be enough, given that if
sal_uInt16 is less than another sal_uInt16, it cannot be equal to greatest
sal_uInt16. But let's keep this redundant comparison, in case types or
define changes later.

Change-Id: I886a0bc847a8c30966dea3ea0670bcee9b43c7f1
Reviewed-on: https://gerrit.libreoffice.org/64021
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

sc/source/ui/view/printfun.cxx

diff --git a/sc/source/ui/view/printfun.cxx b/sc/source/ui/view/printfun.cxx
index 2ba69ec..b2de8a6 100644
--- a/sc/source/ui/view/printfun.cxx
+++ b/sc/source/ui/view/printfun.cxx
@@ -2773,7 +2773,7 @@
{
    sal_uInt16 nRCount = pDoc->GetPrintRangeCount( nPrintTab );
    const ScRange* pThisRange = nullptr;
    if ( nRangeNo != RANGENO_NORANGE || nRangeNo < nRCount )
    if (nRangeNo != RANGENO_NORANGE && nRangeNo < nRCount)
        pThisRange = pDoc->GetPrintRange( nPrintTab, nRangeNo );
    if ( pThisRange )
    {