commit 504d9e75f663497e7ba08ea4124c8a1b06d658ce
author Caolán McNamara <caolanm@redhat.com> Fri Dec 13 15:58:57 2019 +0000
committer Caolán McNamara <caolanm@redhat.com> Sat Dec 14 20:13:59 2019 +0100
tree d302e9d22b4cc66a49ee3f96ad7feb57a7d6a687
parent 1e278d1d0cfb1d5375195aa764739f00633f21e8

tdf#127148 select-all on tabbing into version box in help->about

and allow select-all in readonly multiline edits too.

Arguably this might be a universal settings, but just enable it
for the about dialog for now.

Change-Id: Ic2e64fe26593adf4ae630d1be1a7b196a5a0216c
Reviewed-on: https://gerrit.libreoffice.org/85127
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

vcl/source/edit/vclmedit.cxx

diff --git a/vcl/source/edit/vclmedit.cxx b/vcl/source/edit/vclmedit.cxx
index 0225f79..e21d5c4 100644
--- a/vcl/source/edit/vclmedit.cxx
+++ b/vcl/source/edit/vclmedit.cxx
@@ -852,7 +852,7 @@
    if ( !mbActivePopup )
    {
        bool bGotoCursor = !mpExtTextView->IsReadOnly();
        if ( mbFocusSelectionHide && IsReallyVisible() && !mpExtTextView->IsReadOnly()
        if ( mbFocusSelectionHide && IsReallyVisible()
                && ( mbSelectOnTab &&
                    (!mbInMBDown || ( GetSettings().GetStyleSettings().GetSelectionOptions() & SelectionOptions::Focus ) )) )
        {

vcl/source/window/aboutdialog.cxx

diff --git a/vcl/source/window/aboutdialog.cxx b/vcl/source/window/aboutdialog.cxx
index 879c94d..882b47b0 100644
--- a/vcl/source/window/aboutdialog.cxx
+++ b/vcl/source/window/aboutdialog.cxx
@@ -29,6 +29,14 @@
    m_xBuilder->get(m_xCopyrightText, "copyright");
    m_xBuilder->get(m_xBuildIdLink, "buildIdLink");

    // tdf#127148 so tabbing into the widget will auto select-all
    AllSettings aSettings = m_xVersion->GetSettings();
    StyleSettings aStyleSettings = aSettings.GetStyleSettings();
    aStyleSettings.SetSelectionOptions(aStyleSettings.GetSelectionOptions()
                                       | SelectionOptions::Focus);
    aSettings.SetStyleSettings(aStyleSettings);
    m_xVersion->SetSettings(aSettings, true);

#ifndef MACOSX
    m_xVersion->RequestDoubleBuffering(true);
#endif