| commit | 963330b5605e2350a34405c4752989c43c223b78 | [log] |
|---|---|---|
| author | Eike Rathke <erack@redhat.com> | Wed Feb 16 16:56:52 2022 +0100 |
| committer | Eike Rathke <erack@redhat.com> | Thu Feb 17 11:48:14 2022 +0100 |
| tree | 445b29816f8a3a82a33dfbf8fd01a81389e08903 | |
| parent | a1d08b478a4f55c5e8fc08eb3cf963c2a8107221 [diff] |
Resolves: tdf#147398 Test Intersects() instead of Contains(), tdf#119083 Regression from commit 8406139062d9ffe1daed32aefe4e261c6c55d63e CommitDate: Mon Dec 6 15:45:35 2021 +0100 process broadcasts for adjacent cells together (tdf#119083) that changed single cell broadcasts to blocks of rows broadcasts and - if (rAreaRange.Contains( rAddress)) + if (rAreaRange.Contains( rRange)) but a block of rows may be distributed over several broadcast areas so rRange is not contained within one rAreaRange and thus was not broadcasted. Testing for intersection instead fixes this. Change-Id: I10700296ebc897e4b7b7752e0e6bcb480085b487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130027 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit a1f21d7094deb6f1ae5388718f2bc28eecd5737a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130012 Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
diff --git a/sc/source/core/data/bcaslot.cxx b/sc/source/core/data/bcaslot.cxx index de77239..d2243ea 100644 --- a/sc/source/core/data/bcaslot.cxx +++ b/sc/source/core/data/bcaslot.cxx
@@ -304,7 +304,7 @@ bool ScBroadcastAreaSlot::AreaBroadcast( const ScHint& rHint) ScBroadcastArea* pArea = (*aIter).mpArea; const ScRange& rAreaRange = pArea->GetRange(); if (rAreaRange.In( rRange)) if (rAreaRange.Intersects( rRange)) { if (pArea->IsGroupListening()) {