commit a3519fdde2fd60eb51f867939905e5e3325522c7
author Caolán McNamara <caolanm@redhat.com> Mon Feb 10 16:07:27 2020 +0000
committer Xisco Faulí <xiscofauli@libreoffice.org> Tue Feb 11 13:06:43 2020 +0100
tree 480bb01c52c87d25beccf5c256a2cb171c63c5d5
parent a439d66020965084abbd3a284ebcf9b600334da5

Resolves: tdf#130548 click is sent to the other member of the group

when toggling one the other gets a click signal, but its too
early and the page size isn't set yet, making the dialog thing
the margins won't fit in the page

Change-Id: I5b51f2d91c69558d47f43b3f05eca3fd87a24125
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88387
Tested-by: Jenkins
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>

cui/source/tabpages/page.cxx

diff --git a/cui/source/tabpages/page.cxx b/cui/source/tabpages/page.cxx
index a5e7269..0e61cf3 100644
--- a/cui/source/tabpages/page.cxx
+++ b/cui/source/tabpages/page.cxx
@@ -429,9 +429,17 @@ void SvxPageDescPage::Reset( const SfxItemSet* rSet )
         aPaperSize.Width() > aPaperSize.Height() )
        bLandscape = true;

    // tdf#130548 disable callbacks on the other of a pair of the radiogroup
    // when toggling its partner
    m_xLandscapeBtn->connect_clicked(Link<weld::Button&, void>());
    m_xPortraitBtn->connect_clicked(Link<weld::Button&, void>());

    m_xLandscapeBtn->set_active(bLandscape);
    m_xPortraitBtn->set_active(!bLandscape);

    m_xLandscapeBtn->connect_clicked(LINK(this, SvxPageDescPage, SwapOrientation_Impl));
    m_xPortraitBtn->connect_clicked(LINK(this, SvxPageDescPage, SwapOrientation_Impl));

    m_aBspWin.SetSize( Size( ConvertLong_Impl( aPaperSize.Width(), eUnit ),
                           ConvertLong_Impl( aPaperSize.Height(), eUnit ) ) );