commit a9ed52fca453f14cd38d948eba749248892577e4
author Julian Kalinowski <julian.kalinowski@dataport.de> Tue Mar 31 12:45:31 2020 +0200
committer Xisco Faulí <xiscofauli@libreoffice.org> Wed Apr 01 11:38:23 2020 +0200
tree 7df334582697f7523d229cd3670fe4d1f11d3f33
parent bc6f350d17b9e80e66add73fb6743b16db320b2c

tdf#128662 Fix exception when accessing empty lock list

This fixes an Access Violation Exception when a WebDAV server says a
resource is locked but does return an empty lockdiscovery element on
WebDAV Propfind. Without this patch, the code only checks that a list
exists, but it should also check if it contains elements before
accessing it.

Change-Id: I5f555a9b5805102242392b018ab5a8009c7a203c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91412
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91392
Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
(cherry picked from commit 37cb8ac6abfc9bfd44aed1a51f6374ad1e23583a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91396
Reviewed-by: Julian Kalinowski <julian.kalinowski@dataport.de>
Reviewed-by: Michael Stahl <michael.stahl@cib.de>

sfx2/source/doc/docfile.cxx

diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 0e646ae..5d00d39 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -1206,7 +1206,7 @@ SfxMedium::LockFileResult SfxMedium::LockOrigFileOnDemand(bool bLoading, bool bN

                                uno::Sequence<css::ucb::Lock> aLocks;
                                // getting the property, send a PROPFIND to the server over the net
                                if (aContentToLock.getPropertyValue("DAV:lockdiscovery") >>= aLocks)
                                if ((aContentToLock.getPropertyValue("DAV:lockdiscovery") >>= aLocks) && aLocks.hasElements())
                                {
                                    // got at least a lock, show the owner of the first lock returned
                                    css::ucb::Lock aLock = aLocks[0];