commit ae2d1315766581259756c819f0227270d344f4d4
author Khaled Hosny <khaled@aliftype.com> Sun Nov 27 05:10:29 2022 +0200
committer خالد حسني <khaled@aliftype.com> Sun Nov 27 06:00:56 2022 +0100
tree 709cc84e0f046e8ceeb591b3e1878c6dc6a64c6c
parent 521ba0f495919022a77a189c52f632baef02a05c

tdf#102914: keep font attributes for the substituted fallback font

Setting italic to that of the found font seems to prevent artificial
italic in PDF export. We want to keep the original select pattern
attributes so that we know we asked for italic font but got a non-italic
one.

Change-Id: I0cf400e86d802028dffdabbb98e35e3ee584626e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143339
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@aliftype.com>

vcl/quartz/salgdi.cxx

diff --git a/vcl/quartz/salgdi.cxx b/vcl/quartz/salgdi.cxx
index 661a7e7..1058b7b 100644
--- a/vcl/quartz/salgdi.cxx
+++ b/vcl/quartz/salgdi.cxx
@@ -111,11 +111,6 @@ bool CoreTextGlyphFallbackSubstititution::FindFontSubstitute(vcl::font::FontSele

            rPattern.maSearchName = rAttr.GetFamilyName();

            rPattern.SetWeight(rAttr.GetWeight());
            rPattern.SetItalic(rAttr.GetItalic());
            rPattern.SetPitch(rAttr.GetPitch());
            rPattern.SetWidthType(rAttr.GetWidthType());

            CFRelease(pFallback);
            CFRelease(pDesc);
        }