loplugin:returnconstval in writerperfect

Change-Id: I86e9977438c69c19adafc3743e618321a05e3923
Reviewed-on: https://gerrit.libreoffice.org/78064
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
diff --git a/writerperfect/inc/DirectoryStream.hxx b/writerperfect/inc/DirectoryStream.hxx
index 5fb9d2b..6747c87 100644
--- a/writerperfect/inc/DirectoryStream.hxx
+++ b/writerperfect/inc/DirectoryStream.hxx
@@ -44,7 +44,7 @@ public:
    static std::unique_ptr<DirectoryStream>
    createForParent(const css::uno::Reference<css::ucb::XContent>& xContent);

    const css::uno::Reference<css::ucb::XContent> getContent() const;
    css::uno::Reference<css::ucb::XContent> getContent() const;

    virtual bool isStructured() override;
    virtual unsigned subStreamCount() override;
diff --git a/writerperfect/inc/DocumentHandlerFor.hxx b/writerperfect/inc/DocumentHandlerFor.hxx
index 0f31b85..d90039e 100644
--- a/writerperfect/inc/DocumentHandlerFor.hxx
+++ b/writerperfect/inc/DocumentHandlerFor.hxx
@@ -16,7 +16,7 @@ namespace writerperfect
  */
template <class Generator> struct DocumentHandlerFor
{
    // static const OUString name();
    // static OUString name();
};
}

diff --git a/writerperfect/inc/DocumentHandlerForOdg.hxx b/writerperfect/inc/DocumentHandlerForOdg.hxx
index 72968ed..9d46bcb 100644
--- a/writerperfect/inc/DocumentHandlerForOdg.hxx
+++ b/writerperfect/inc/DocumentHandlerForOdg.hxx
@@ -16,7 +16,7 @@ namespace writerperfect
{
template <> struct DocumentHandlerFor<OdgGenerator>
{
    static const OUString name() { return "com.sun.star.comp.Draw.XMLOasisImporter"; }
    static OUString name() { return "com.sun.star.comp.Draw.XMLOasisImporter"; }
};
}

diff --git a/writerperfect/inc/DocumentHandlerForOdp.hxx b/writerperfect/inc/DocumentHandlerForOdp.hxx
index c919514..9ef3681 100644
--- a/writerperfect/inc/DocumentHandlerForOdp.hxx
+++ b/writerperfect/inc/DocumentHandlerForOdp.hxx
@@ -16,7 +16,7 @@ namespace writerperfect
{
template <> struct DocumentHandlerFor<OdpGenerator>
{
    static const OUString name() { return "com.sun.star.comp.Impress.XMLOasisImporter"; }
    static OUString name() { return "com.sun.star.comp.Impress.XMLOasisImporter"; }
};
}

diff --git a/writerperfect/inc/DocumentHandlerForOds.hxx b/writerperfect/inc/DocumentHandlerForOds.hxx
index 4ee2681..a739443 100644
--- a/writerperfect/inc/DocumentHandlerForOds.hxx
+++ b/writerperfect/inc/DocumentHandlerForOds.hxx
@@ -16,7 +16,7 @@ namespace writerperfect
{
template <> struct DocumentHandlerFor<OdsGenerator>
{
    static const OUString name() { return "com.sun.star.comp.Calc.XMLOasisImporter"; }
    static OUString name() { return "com.sun.star.comp.Calc.XMLOasisImporter"; }
};
}

diff --git a/writerperfect/inc/DocumentHandlerForOdt.hxx b/writerperfect/inc/DocumentHandlerForOdt.hxx
index ea3742a..b454e57d 100644
--- a/writerperfect/inc/DocumentHandlerForOdt.hxx
+++ b/writerperfect/inc/DocumentHandlerForOdt.hxx
@@ -16,7 +16,7 @@ namespace writerperfect
{
template <> struct DocumentHandlerFor<OdtGenerator>
{
    static const OUString name() { return "com.sun.star.comp.Writer.XMLOasisImporter"; }
    static OUString name() { return "com.sun.star.comp.Writer.XMLOasisImporter"; }
};
}

diff --git a/writerperfect/qa/unit/WPXSvStreamTest.cxx b/writerperfect/qa/unit/WPXSvStreamTest.cxx
index ef246af..b13fc91e 100644
--- a/writerperfect/qa/unit/WPXSvStreamTest.cxx
+++ b/writerperfect/qa/unit/WPXSvStreamTest.cxx
@@ -83,7 +83,7 @@ shared_ptr<RVNGInputStream> lcl_createStream()
    return pInputStream;
}

const shared_ptr<RVNGInputStream> lcl_createStreamForURL(const OUString& rURL)
shared_ptr<RVNGInputStream> lcl_createStreamForURL(const OUString& rURL)
{
    using uno::Reference;
    using uno::UNO_QUERY_THROW;
@@ -97,8 +97,7 @@ const shared_ptr<RVNGInputStream> lcl_createStreamForURL(const OUString& rURL)
    const Reference<io::XInputStream> xInputStream(xFileAccess->openFileRead(rURL),
                                                   css::uno::UNO_SET_THROW);

    const shared_ptr<RVNGInputStream> pInput(new WPXSvInputStream(xInputStream));
    return pInput;
    return shared_ptr<RVNGInputStream>(new WPXSvInputStream(xInputStream));
}

void lcl_testSubStreams(const shared_ptr<RVNGInputStream>& pInput)
diff --git a/writerperfect/source/common/DirectoryStream.cxx b/writerperfect/source/common/DirectoryStream.cxx
index d6d3914..19ec454 100644
--- a/writerperfect/source/common/DirectoryStream.cxx
+++ b/writerperfect/source/common/DirectoryStream.cxx
@@ -157,7 +157,7 @@ DirectoryStream::createForParent(const css::uno::Reference<css::ucb::XContent>& 
    }
}

const css::uno::Reference<css::ucb::XContent> DirectoryStream::getContent() const
css::uno::Reference<css::ucb::XContent> DirectoryStream::getContent() const
{
    if (!m_pImpl)
        return css::uno::Reference<css::ucb::XContent>();
diff --git a/writerperfect/source/common/WPXSvInputStream.cxx b/writerperfect/source/common/WPXSvInputStream.cxx
index 4b57b25..f1799f5 100644
--- a/writerperfect/source/common/WPXSvInputStream.cxx
+++ b/writerperfect/source/common/WPXSvInputStream.cxx
@@ -86,7 +86,7 @@ OUString lcl_normalizeSubStreamPath(const OUString& rPath)

namespace
{
const OUString concatPath(const OUString& lhs, const OUString& rhs)
OUString concatPath(const OUString& lhs, const OUString& rhs)
{
    if (lhs.isEmpty())
        return rhs;