commit bb51f81507a405266d251297684bd3ab60998197
author Julien Nabet <serval2412@yahoo.fr> Sun Mar 08 13:58:35 2020 +0100
committer Julien Nabet <serval2412@yahoo.fr> Sun Mar 08 16:34:59 2020 +0100
tree e04cba9e11bc65bc290a3826dee3d50f6c7d7e25
parent 3ddfba19c964a65a5bfa1c172e83532af305c985

tdf#131217: position arg in Blob::getBytes begins at 1 not 0 (Firebird)

See part of bt here:
https://bugs.documentfoundation.org/show_bug.cgi?id=131217#c5

According to:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=38ce989b4f9d2aead097e5a2e95b819def7e2624
position can't be 0

Change-Id: Ia7bf973b820b8642b45eb0bbc125011cab99de9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90186
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>

connectivity/source/drivers/firebird/DatabaseMetaData.cxx

diff --git a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
index 3fb6435..32e3970 100644
--- a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
+++ b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
@@ -1248,7 +1248,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getColumns(
            if (xDescriptionBlob.is())
            {
                sal_Int32 aBlobLength = static_cast<sal_Int32>(xDescriptionBlob->length());
                aDescription = OUString(reinterpret_cast<char*>(xDescriptionBlob->getBytes(0, aBlobLength).getArray()),
                aDescription = OUString(reinterpret_cast<char*>(xDescriptionBlob->getBytes(1, aBlobLength).getArray()),
                                        aBlobLength,
                                        RTL_TEXTENCODING_UTF8);
            }
@@ -1415,7 +1415,7 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTables(
                // TODO: we should actually be using CLOB here instead.
                // However we haven't implemented CLOB yet, so use BLOB.
                sal_Int32 aBlobLength = static_cast<sal_Int32>(xBlob->length());
                sDescription = OUString(reinterpret_cast<char*>(xBlob->getBytes(0, aBlobLength).getArray()),
                sDescription = OUString(reinterpret_cast<char*>(xBlob->getBytes(1, aBlobLength).getArray()),
                                        aBlobLength,
                                        RTL_TEXTENCODING_UTF8);
            }