commit bc63974e9d82a6ff7954618add266f967fa428eb
author Mike Kaganski <mike.kaganski@collabora.com> Sun Nov 11 23:03:45 2018 +0300
committer Eike Rathke <erack@redhat.com> Mon Nov 12 18:19:08 2018 +0100
tree 47bf715eb3e40cae68653c23136cd8faca654249
parent 5b8b72cbdc6407bf806eab14b2d29bb72cf21cd6

tdf#120703 PVS: V560 Properly compare current to cDecimalSepAlt

V560 A part of conditional expression is always false: current == cDecimalSep.

Assuming a copypaste error in commit 21052ba2edeef9e16bf90fea62f007b1131c73c0.
Compare to a similar case below (line 817).

Change-Id: Iebd84aa8df3e37b9a5e4fdc7ce7a25a0704a260f
Reviewed-on: https://gerrit.libreoffice.org/63269
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>

i18npool/source/characterclassification/cclass_unicode_parser.cxx

diff --git a/i18npool/source/characterclassification/cclass_unicode_parser.cxx b/i18npool/source/characterclassification/cclass_unicode_parser.cxx
index 96882a8..8cca988 100644
--- a/i18npool/source/characterclassification/cclass_unicode_parser.cxx
+++ b/i18npool/source/characterclassification/cclass_unicode_parser.cxx
@@ -745,7 +745,7 @@
                        else
                            r.TokenType = KParseType::ASC_NUMBER;
                    }
                    else if (current == cDecimalSep || (bDecSepAltUsed = (cDecimalSepAlt && current == cDecimalSep)))
                    else if (current == cDecimalSep || (bDecSepAltUsed = (cDecimalSepAlt && current == cDecimalSepAlt)))
                    {
                        if (nextChar)
                            ++nDecSeps;