| commit | c016fe2b5918d6e53113e100b1126076b6e1a6a3 | [log] |
|---|---|---|
| author | Justin Luth <justin.luth@collabora.com> | Fri Jul 24 08:11:54 2020 +0300 |
| committer | Justin Luth <justin_luth@sil.org> | Fri Jul 24 13:41:59 2020 +0200 |
| tree | 376b160a107c2626cf45b32baadb46bbfe609ffe | |
| parent | b827eefd6397dc34b49a03e186146aed6cd80042 [diff] |
tdf#99492 sw layout: always paint merged cell grids So the logic goes like this: 1.) paint table background 2.) paint row X background 3.) paint row X's cell backgrounds So far so good. The cell background overrides all others. 4.) paint row Y background. Well, now it has painted over top of any merged Y grids, and thus covered cells need to paint themselves again. 5.) paint row Y's cells, NOT excluding covered cells. Dropping this "optimization" of ignoring the covered cell shouldn't impact performance too much since merged cells are not super common. One alternative option would be to determine if the row has a background fill, and only paint all the merged grids in that case. But that isn't trivial, and so the processing of determining that might as well be used to just paint the cell background again. The only other option is to paint all rows first, and then paint all the cells. But the logic of this generic function doesn't easily allow for that. Unfortunately, I couldn't see how to create a unit test since layout.xml doesn't include color at all. However, Office Interoperability Testing should catch it since there are a couple of clear examples attached to the bug report. Change-Id: Ie2c3776ab062dbb51c88134291e8901e71838b18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99343 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
LibreOffice is an integrated office suite based on copyleft licenses and compatible with most document formats and standards. Libreoffice is backed by The Document Foundation, which represents a large independent community of enterprises, developers and other volunteers moved by the common goal of bringing to the market the best software for personal productivity. LibreOffice is open source, and free to download, use and distribute.
A quick overview of the LibreOffice code structure.
You can develop for LibreOffice in one of two ways, one recommended and one much less so. First the somewhat less recommended way: it is possible to use the SDK to develop an extension, for which you can read the API docs here and here. This re-uses the (extremely generic) UNO APIs that are also used by macro scripting in StarBasic.
The best way to add a generally useful feature to LibreOffice is to work on the code base however. Overall this way makes it easier to compile and build your code, it avoids any arbitrary limitations of our scripting APIs, and in general is far more simple and intuitive - if you are a reasonably able C++ programmer.
These are the current minimal operating system and compiler versions to run and compile LibreOffice, also used by the TDF builds:
If you want to use Clang with the LibreOffice compiler plugins, the minimal version of Clang is 5.0.2. Since Xcode doesn't provide the compiler plugin headers, you have to compile your own Clang to use them on macOS.
You can find the TDF configure switches in the distro-configs/ directory.
To setup your initial build environment on Windows and macOS, we provide the LibreOffice Development Environment (LODE) scripts.
For more information see the build instructions for your platform in the TDF wiki.
Each module should have a README file inside it which has some degree of documentation for that module; patches are most welcome to improve those. We have those turned into a web page here:
However, there are two hundred modules, many of them of only peripheral interest for a specialist audience. So - where is the good stuff, the code that is most useful. Here is a quick overview of the most important ones:
| Module | Description |
|---|---|
| sal/ | this provides a simple System Abstraction Layer |
| tools/ | this provides basic internal types: 'Rectangle', 'Color' etc. |
| vcl/ | this is the widget toolkit library and one rendering abstraction |
| framework | UNO framework, responsible for building toolbars, menus, status bars, and the chrome around the document using widgets from VCL, and XML descriptions from /uiconfig/ files |
| sfx2/ | legacy core framework used by Writer/Calc/Draw: document model / load/save / signals for actions etc. |
| svx/ | drawing model related helper code, including much of Draw/Impress |
Then applications
| Module | Description |
|---|---|
| desktop/ | this is where the 'main' for the application lives, init / bootstrap. the name dates back to an ancient StarOffice that also drew a desktop |
| sw/ | Writer |
| sc/ | Calc |
| sd/ | Draw / Impress |
There are several other libraries that are helpful from a graphical perspective:
| Module | Description |
|---|---|
| basegfx/ | algorithms and data-types for graphics as used in the canvas |
| canvas/ | new (UNO) canvas rendering model with various backends |
| cppcanvas/ | C++ helper classes for using the UNO canvas |
| drawinglayer/ | View code to render drawable objects and break them down into primitives we can render more easily. |
Use the "..." form if and only if the included file is found next to the including file. Otherwise, use the <...> form. (For further details, see the mail Re: C[++]: Normalizing include syntax ("" vs <>).)
The UNO API include files should consistently use double quotes, for the benefit of external users of this API.
loplugin:includeform (compilerplugins/clang/includeform.cxx) enforces these rules.
Beyond this, you can read the README files, send us patches, ask on the mailing list libreoffice@lists.freedesktop.org (no subscription required) or poke people on IRC #libreoffice-dev on irc.freenode.net - we're a friendly and generally helpful mob. We know the code can be hard to get into at first, and so there are no silly questions.