loplugin:constparams in basctl
Change-Id: If6c2b980a2916c4ee8ac108fbb84b006a35f49c5
Reviewed-on: https://gerrit.libreoffice.org/40570
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
diff --git a/basctl/inc/iderdll.hxx b/basctl/inc/iderdll.hxx
index 83f92f8..0087c91 100644
--- a/basctl/inc/iderdll.hxx
+++ b/basctl/inc/iderdll.hxx
@@ -30,7 +30,7 @@ void EnsureIde ();
void ShellCreated (Shell* pShell);
Shell* GetShell();
void ShellDestroyed (Shell* pShell);
void ShellDestroyed (Shell const * pShell);
ExtraData* GetExtraData();
diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index b3b3c44..300114d 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -177,7 +177,7 @@ void lcl_ConvertTabsToSpaces( OUString& rLine )
} // namespace
ModulWindow::ModulWindow (ModulWindowLayout* pParent, ScriptDocument const& rDocument,
const OUString& aLibName, const OUString& aName, OUString& aModule)
const OUString& aLibName, const OUString& aName, OUString const & aModule)
: BaseWindow(pParent, rDocument, aLibName, aName)
, m_rLayout(*pParent)
, m_nValid(ValidWindow)
@@ -587,7 +587,7 @@ void ModulWindow::ManageBreakPoints()
}
bool ModulWindow::BasicErrorHdl( StarBASIC * pBasic )
bool ModulWindow::BasicErrorHdl( StarBASIC const * pBasic )
{
GetShell()->GetViewFrame()->ToTop();
diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx
index 0653952..46d0d43 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -157,7 +157,7 @@ public:
void ChangeFontColor( Color aColor );
void UpdateSyntaxHighlighting ();
bool GetProcedureName(OUString& rLine, OUString& rProcType, OUString& rProcName) const;
bool GetProcedureName(OUString const & rLine, OUString& rProcType, OUString& rProcName) const;
};
@@ -322,7 +322,7 @@ protected:
virtual void DoScroll( ScrollBar* pCurScrollBar ) override;
public:
ModulWindow( ModulWindowLayout* pParent, const ScriptDocument& rDocument, const OUString& aLibName, const OUString& aName, OUString& aModule );
ModulWindow( ModulWindowLayout* pParent, const ScriptDocument& rDocument, const OUString& aLibName, const OUString& aName, OUString const & aModule );
virtual ~ModulWindow() override;
virtual void dispose() override;
@@ -361,7 +361,7 @@ public:
void UpdateBreakPoint( const BreakPoint& rBrk );
void BasicAddWatch();
bool BasicErrorHdl( StarBASIC* pBasic );
bool BasicErrorHdl( StarBASIC const * pBasic );
BasicDebugFlags BasicBreakHdl();
void AssertValidEditEngine();
diff --git a/basctl/source/basicide/baside2b.cxx b/basctl/source/basicide/baside2b.cxx
index 631ab8a..ef902a1 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -122,7 +122,7 @@ void setTextEngineText (ExtTextEngine& rEngine, OUString const& aStr)
namespace
{
void lcl_DrawIDEWindowFrame(DockingWindow* pWin, vcl::RenderContext& rRenderContext)
void lcl_DrawIDEWindowFrame(DockingWindow const * pWin, vcl::RenderContext& rRenderContext)
{
if (pWin->IsFloatingMode())
return;
@@ -783,7 +783,7 @@ void EditorWindow::HandleProcedureCompletion()
}
}
bool EditorWindow::GetProcedureName(OUString& rLine, OUString& rProcType, OUString& rProcName) const
bool EditorWindow::GetProcedureName(OUString const & rLine, OUString& rProcType, OUString& rProcName) const
{
std::vector<HighlightPortion> aPortions;
aHighlighter.getHighlightPortions(rLine, aPortions);
diff --git a/basctl/source/basicide/basides1.cxx b/basctl/source/basicide/basides1.cxx
index d1083a6..5fb85ec 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -1162,7 +1162,7 @@ VclPtr<BaseWindow> Shell::FindWindow(
return nullptr;
}
bool Shell::CallBasicErrorHdl( StarBASIC* pBasic )
bool Shell::CallBasicErrorHdl( StarBASIC const * pBasic )
{
bool bRet = false;
VclPtr<ModulWindow> pModWin = ShowActiveModuleWindow( pBasic );
@@ -1171,7 +1171,7 @@ bool Shell::CallBasicErrorHdl( StarBASIC* pBasic )
return bRet;
}
BasicDebugFlags Shell::CallBasicBreakHdl( StarBASIC* pBasic )
BasicDebugFlags Shell::CallBasicBreakHdl( StarBASIC const * pBasic )
{
BasicDebugFlags nRet = BasicDebugFlags::NONE;
VclPtr<ModulWindow> pModWin = ShowActiveModuleWindow( pBasic );
@@ -1201,7 +1201,7 @@ BasicDebugFlags Shell::CallBasicBreakHdl( StarBASIC* pBasic )
return nRet;
}
VclPtr<ModulWindow> Shell::ShowActiveModuleWindow( StarBASIC* pBasic )
VclPtr<ModulWindow> Shell::ShowActiveModuleWindow( StarBASIC const * pBasic )
{
SetCurLib( ScriptDocument::getApplicationScriptDocument(), OUString(), false );
diff --git a/basctl/source/basicide/basobj3.cxx b/basctl/source/basicide/basobj3.cxx
index 4b4128c..00c6ea0 100644
--- a/basctl/source/basicide/basobj3.cxx
+++ b/basctl/source/basicide/basobj3.cxx
@@ -44,9 +44,9 @@ using namespace ::com::sun::star::uno;
using namespace ::com::sun::star::container;
extern "C" {
SAL_DLLPUBLIC_EXPORT long basicide_handle_basic_error( void* pPtr )
SAL_DLLPUBLIC_EXPORT long basicide_handle_basic_error( void const * pPtr )
{
return HandleBasicError( static_cast<StarBASIC*>(pPtr) );
return HandleBasicError( static_cast<StarBASIC const *>(pPtr) );
}
}
@@ -212,7 +212,7 @@ StarBASIC* FindBasic( const SbxVariable* pVar )
return const_cast<StarBASIC*>(static_cast<const StarBASIC*>(pSbx));
}
BasicManager* FindBasicManager( StarBASIC* pLib )
BasicManager* FindBasicManager( StarBASIC const * pLib )
{
ScriptDocuments aDocuments( ScriptDocument::getAllScriptDocuments( ScriptDocument::AllWithApplication ) );
for ( ScriptDocuments::const_iterator doc = aDocuments.begin();
@@ -263,7 +263,7 @@ void MarkDocumentModified( const ScriptDocument& rDocument )
}
}
void RunMethod( SbMethod* pMethod )
void RunMethod( SbMethod const * pMethod )
{
SbxValues aRes;
aRes.eType = SbxVOID;
@@ -355,7 +355,7 @@ void InvalidateDebuggerSlots()
}
}
long HandleBasicError( StarBASIC* pBasic )
long HandleBasicError( StarBASIC const * pBasic )
{
EnsureIde();
BasicStopped();
diff --git a/basctl/source/basicide/bastype2.cxx b/basctl/source/basicide/bastype2.cxx
index f85b8ce..beb4be4 100644
--- a/basctl/source/basicide/bastype2.cxx
+++ b/basctl/source/basicide/bastype2.cxx
@@ -581,7 +581,7 @@ void TreeListBox::UpdateEntries()
}
// Removes the entry from the tree.
void TreeListBox::RemoveEntry (SvTreeListEntry* pEntry)
void TreeListBox::RemoveEntry (SvTreeListEntry const * pEntry)
{
// removing the associated user data
delete static_cast<Entry*>(pEntry->GetUserData());
@@ -780,7 +780,7 @@ void TreeListBox::GetRootEntryBitmaps( const ScriptDocument& rDocument, Image& r
}
}
void TreeListBox::SetCurrentEntry (EntryDescriptor& rDesc)
void TreeListBox::SetCurrentEntry (EntryDescriptor const & rDesc)
{
SvTreeListEntry* pCurEntry = nullptr;
EntryDescriptor aDesc = rDesc;
diff --git a/basctl/source/basicide/iderdll.cxx b/basctl/source/basicide/iderdll.cxx
index 0773338..7a2b80a 100644
--- a/basctl/source/basicide/iderdll.cxx
+++ b/basctl/source/basicide/iderdll.cxx
@@ -91,7 +91,7 @@ void ShellCreated (Shell* pShell)
pDll->SetShell(pShell);
}
void ShellDestroyed (Shell* pShell)
void ShellDestroyed (Shell const * pShell)
{
Dll* pDll = theDllInstance::get().get();
if (pDll && pDll->GetShell() == pShell)
diff --git a/basctl/source/basicide/iderdll2.hxx b/basctl/source/basicide/iderdll2.hxx
index cd24840..feb9e0e 100644
--- a/basctl/source/basicide/iderdll2.hxx
+++ b/basctl/source/basicide/iderdll2.hxx
@@ -57,7 +57,7 @@ public:
LibInfo& GetLibInfo () { return aLibInfo; }
EntryDescriptor& GetLastEntryDescriptor () { return m_aLastEntryDesc; }
void SetLastEntryDescriptor (EntryDescriptor& rDesc) { m_aLastEntryDesc = rDesc; }
void SetLastEntryDescriptor (EntryDescriptor const & rDesc) { m_aLastEntryDesc = rDesc; }
bool& ChoosingMacro() { return bChoosingMacro; }
bool& ShellInCriticalSection() { return bShellInCriticalSection; }
diff --git a/basctl/source/basicide/localizationmgr.cxx b/basctl/source/basicide/localizationmgr.cxx
index 1af9b12..6150cc7 100644
--- a/basctl/source/basicide/localizationmgr.cxx
+++ b/basctl/source/basicide/localizationmgr.cxx
@@ -774,7 +774,7 @@ void LocalizationMgr::handleBasicStopped()
}
DialogWindow* FindDialogWindowForEditor( DlgEditor* pEditor )
DialogWindow* FindDialogWindowForEditor( DlgEditor const * pEditor )
{
Shell::WindowTable const& aWindowTable = GetShell()->GetWindowTable();
for (Shell::WindowTableIt it = aWindowTable.begin(); it != aWindowTable.end(); ++it )
@@ -791,7 +791,7 @@ DialogWindow* FindDialogWindowForEditor( DlgEditor* pEditor )
}
void LocalizationMgr::setControlResourceIDsForNewEditorObject( DlgEditor* pEditor,
void LocalizationMgr::setControlResourceIDsForNewEditorObject( DlgEditor const * pEditor,
const Any& rControlAny, const OUString& aCtrlName )
{
// Get library for DlgEditor
@@ -821,7 +821,7 @@ void LocalizationMgr::setControlResourceIDsForNewEditorObject( DlgEditor* pEdito
MarkDocumentModified( aDocument );
}
void LocalizationMgr::renameControlResourceIDsForEditorObject( DlgEditor* pEditor,
void LocalizationMgr::renameControlResourceIDsForEditorObject( DlgEditor const * pEditor,
const css::uno::Any& rControlAny, const OUString& aNewCtrlName )
{
// Get library for DlgEditor
@@ -849,7 +849,7 @@ void LocalizationMgr::renameControlResourceIDsForEditorObject( DlgEditor* pEdito
}
void LocalizationMgr::deleteControlResourceIDsForDeletedEditorObject( DlgEditor* pEditor,
void LocalizationMgr::deleteControlResourceIDsForDeletedEditorObject( DlgEditor const * pEditor,
const Any& rControlAny, const OUString& aCtrlName )
{
// Get library for DlgEditor
@@ -1019,7 +1019,7 @@ void LocalizationMgr::setResourceIDsForDialog( const Reference< container::XName
}
}
void LocalizationMgr::copyResourcesForPastedEditorObject( DlgEditor* pEditor,
void LocalizationMgr::copyResourcesForPastedEditorObject( DlgEditor const * pEditor,
const Any& rControlAny, const OUString& aCtrlName,
const Reference< XStringResourceResolver >& xSourceStringResolver )
{
diff --git a/basctl/source/basicide/moduldlg.cxx b/basctl/source/basicide/moduldlg.cxx
index 81b7a6e..5fd341d 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -306,7 +306,7 @@ void Shell::CopyDialogResources(
}
}
TriState ExtTreeListBox::NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeListEntry* pEntry,
TriState ExtTreeListBox::NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeListEntry const * pEntry,
SvTreeListEntry*& rpNewParent, sal_uLong& rNewChildPos, bool bMove )
{
DBG_ASSERT( pEntry, "No entry?" ); // ASS is ok here, should not be reached
@@ -451,7 +451,7 @@ TriState ExtTreeListBox::NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeLi
// OrganizeDialog
OrganizeDialog::OrganizeDialog(vcl::Window* pParent, sal_Int16 tabId,
EntryDescriptor& rDesc )
EntryDescriptor const & rDesc )
: TabDialog( pParent, "OrganizeDialog",
"modules/BasicIDE/ui/organizedialog.ui" )
, m_aCurEntry( rDesc )
@@ -597,7 +597,7 @@ void ObjectPage::dispose()
TabPage::dispose();
}
void ObjectPage::SetCurrentEntry (EntryDescriptor& rDesc)
void ObjectPage::SetCurrentEntry (EntryDescriptor const & rDesc)
{
m_pBasicBox->SetCurrentEntry( rDesc );
}
diff --git a/basctl/source/basicide/moduldlg.hxx b/basctl/source/basicide/moduldlg.hxx
index 39bd7d8..ee9c90c 100644
--- a/basctl/source/basicide/moduldlg.hxx
+++ b/basctl/source/basicide/moduldlg.hxx
@@ -104,7 +104,7 @@ protected:
SvTreeListEntry*& rpNewParent, sal_uLong& rNewChildPos ) override;
virtual TriState NotifyCopying( SvTreeListEntry* pTarget, SvTreeListEntry* pEntry,
SvTreeListEntry*& rpNewParent, sal_uLong& rNewChildPos ) override;
TriState NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeListEntry* pEntry,
TriState NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeListEntry const * pEntry,
SvTreeListEntry*& rpNewParent, sal_uLong& rNewChildPos, bool bMove );
public:
@@ -168,7 +168,7 @@ private:
EntryDescriptor m_aCurEntry;
public:
OrganizeDialog( vcl::Window* pParent, sal_Int16 tabId, EntryDescriptor& rDesc );
OrganizeDialog( vcl::Window* pParent, sal_Int16 tabId, EntryDescriptor const & rDesc );
virtual ~OrganizeDialog() override;
virtual void dispose() override;
@@ -203,7 +203,7 @@ public:
virtual ~ObjectPage() override;
virtual void dispose() override;
void SetCurrentEntry( EntryDescriptor& rDesc );
void SetCurrentEntry( EntryDescriptor const & rDesc );
void SetTabDlg( TabDialog* p ) { pTabDlg = p;}
};
diff --git a/basctl/source/inc/basidesh.hxx b/basctl/source/inc/basidesh.hxx
index 6311778..6e5aa6f 100644
--- a/basctl/source/inc/basidesh.hxx
+++ b/basctl/source/inc/basidesh.hxx
@@ -115,7 +115,7 @@ private:
VclPtr<ModulWindow> CreateBasWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rModName );
VclPtr<DialogWindow> CreateDlgWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rDlgName );
VclPtr<ModulWindow> ShowActiveModuleWindow( StarBASIC* pBasic );
VclPtr<ModulWindow> ShowActiveModuleWindow( StarBASIC const * pBasic );
virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
@@ -176,8 +176,8 @@ public:
virtual bool HasUIFeature(SfxShellFeature nFeature) const override;
bool CallBasicErrorHdl( StarBASIC* pBasic );
BasicDebugFlags CallBasicBreakHdl( StarBASIC* pBasic );
bool CallBasicErrorHdl( StarBASIC const * pBasic );
BasicDebugFlags CallBasicBreakHdl( StarBASIC const * pBasic );
VclPtr<BaseWindow> FindWindow( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rName, ItemType nType, bool bFindSuspended = false );
VclPtr<DialogWindow> FindDlgWin( const ScriptDocument& rDocument, const OUString& rLibName, const OUString& rName, bool bCreateIfNotExist = false, bool bFindSuspended = false );
diff --git a/basctl/source/inc/basobj.hxx b/basctl/source/inc/basobj.hxx
index 8b10c60..8e5e9ba 100644
--- a/basctl/source/inc/basobj.hxx
+++ b/basctl/source/inc/basobj.hxx
@@ -39,17 +39,17 @@ namespace basctl
// help methods for the general use:
SbMethod* CreateMacro( SbModule* pModule, const OUString& rMacroName );
void RunMethod( SbMethod* pMethod );
void RunMethod( SbMethod const * pMethod );
StarBASIC* FindBasic( const SbxVariable* pVar );
void StopBasic();
long HandleBasicError( StarBASIC* pBasic );
long HandleBasicError( StarBASIC const * pBasic );
void BasicStopped( bool* pbAppWindowDisabled = nullptr, bool* pbDispatcherLocked = nullptr, sal_uInt16* pnWaitCount = nullptr,
SfxUInt16Item** ppSWActionCount = nullptr, SfxUInt16Item** ppSWLockViewCount = nullptr );
bool IsValidSbxName( const OUString& rName );
BasicManager* FindBasicManager( StarBASIC* pLib );
BasicManager* FindBasicManager( StarBASIC const * pLib );
SfxBindings* GetBindingsPtr();
diff --git a/basctl/source/inc/bastype2.hxx b/basctl/source/inc/bastype2.hxx
index 23c777d..262cd01 100644
--- a/basctl/source/inc/bastype2.hxx
+++ b/basctl/source/inc/bastype2.hxx
@@ -235,13 +235,13 @@ public:
SvTreeListEntry* pParent, bool bChildrenOnDemand,
std::unique_ptr<Entry> && aUserData
);
void RemoveEntry (SvTreeListEntry*);
void RemoveEntry (SvTreeListEntry const *);
void RemoveEntry (ScriptDocument const&);
OUString GetRootEntryName( const ScriptDocument& rDocument, LibraryLocation eLocation ) const;
static void GetRootEntryBitmaps( const ScriptDocument& rDocument, Image& rImage );
void SetCurrentEntry (EntryDescriptor&);
void SetCurrentEntry (EntryDescriptor const &);
private:
LibraryType GetLibraryType() const;
diff --git a/basctl/source/inc/localizationmgr.hxx b/basctl/source/inc/localizationmgr.hxx
index 15f9bac..906fed0 100644
--- a/basctl/source/inc/localizationmgr.hxx
+++ b/basctl/source/inc/localizationmgr.hxx
@@ -95,13 +95,13 @@ public:
void handleBasicStopped();
static void setControlResourceIDsForNewEditorObject(DlgEditor* pEditor,
static void setControlResourceIDsForNewEditorObject(DlgEditor const * pEditor,
const css::uno::Any& rControlAny, const OUString& aCtrlName);
static void renameControlResourceIDsForEditorObject(DlgEditor* pEditor,
static void renameControlResourceIDsForEditorObject(DlgEditor const * pEditor,
const css::uno::Any& rControlAny, const OUString& aNewCtrlName);
static void deleteControlResourceIDsForDeletedEditorObject(DlgEditor* pEditor,
static void deleteControlResourceIDsForDeletedEditorObject(DlgEditor const * pEditor,
const css::uno::Any& rControlAny, const OUString& aCtrlName);
static void setStringResourceAtDialog( const ScriptDocument& rDocument, const OUString& aLibName, const OUString& aDlgName,
@@ -125,7 +125,7 @@ public:
const css::uno::Reference< css::container::XNameContainer >& xDialogModel,
const css::uno::Reference< css::resource::XStringResourceManager >& xStringResourceManager );
static void copyResourcesForPastedEditorObject( DlgEditor* pEditor,
static void copyResourcesForPastedEditorObject( DlgEditor const * pEditor,
const css::uno::Any& rControlAny, const OUString& aCtrlName,
const css::uno::Reference< css::resource::XStringResourceResolver >& xSourceStringResolver );
diff --git a/compilerplugins/clang/constparams.cxx b/compilerplugins/clang/constparams.cxx
index 93b325a..25e8763 100644
--- a/compilerplugins/clang/constparams.cxx
+++ b/compilerplugins/clang/constparams.cxx
@@ -155,6 +155,10 @@ bool ConstParams::VisitFunctionDecl(const FunctionDecl * functionDecl)
|| name == "ImpGetPercent"
|| name == "ImpGetAlign"
|| name == "write_function"
|| name == "PyUNO_getattr"
|| name == "PyUNO_setattr"
|| name == "PyUNOStruct_setattr"
|| name == "PyUNOStruct_getattr"
// #ifdef win32
|| name == "convert_slashes"
// UNO component entry points
diff --git a/i18npool/inc/breakiteratorImpl.hxx b/i18npool/inc/breakiteratorImpl.hxx
index 499a493..8ae8d254 100644
--- a/i18npool/inc/breakiteratorImpl.hxx
+++ b/i18npool/inc/breakiteratorImpl.hxx
@@ -111,7 +111,7 @@ protected:
private:
struct lookupTableItem {
lookupTableItem(const css::lang::Locale& _aLocale, css::uno::Reference < XBreakIterator >& _xBI) : aLocale(_aLocale), xBI(_xBI) {};
lookupTableItem(const css::lang::Locale& _aLocale, css::uno::Reference < XBreakIterator > const & _xBI) : aLocale(_aLocale), xBI(_xBI) {};
css::lang::Locale aLocale;
css::uno::Reference < XBreakIterator > xBI;
};
diff --git a/i18npool/inc/calendarImpl.hxx b/i18npool/inc/calendarImpl.hxx
index 06fe9be..ce0b9f6 100644
--- a/i18npool/inc/calendarImpl.hxx
+++ b/i18npool/inc/calendarImpl.hxx
@@ -95,7 +95,7 @@ public:
private:
struct lookupTableItem {
lookupTableItem(const OUString& _uniqueID, css::uno::Reference < css::i18n::XCalendar4 >& _xCalendar)
lookupTableItem(const OUString& _uniqueID, css::uno::Reference < css::i18n::XCalendar4 > const & _xCalendar)
: uniqueID(_uniqueID), xCalendar(_xCalendar) {}
OUString uniqueID;
css::uno::Reference < css::i18n::XCalendar4 > xCalendar;
diff --git a/i18npool/inc/characterclassificationImpl.hxx b/i18npool/inc/characterclassificationImpl.hxx
index 2102c82..659b342 100644
--- a/i18npool/inc/characterclassificationImpl.hxx
+++ b/i18npool/inc/characterclassificationImpl.hxx
@@ -69,8 +69,8 @@ public:
private:
struct lookupTableItem {
lookupTableItem(const css::lang::Locale& rLocale, const OUString& rName,
css::uno::Reference < XCharacterClassification >& rxCI) :
aLocale(rLocale), aName(rName), xCI(rxCI) {};
css::uno::Reference < XCharacterClassification > const & rxCI) :
aLocale(rLocale), aName(rName), xCI(rxCI) {};
css::lang::Locale aLocale;
OUString aName;
css::uno::Reference < XCharacterClassification > xCI;
diff --git a/i18npool/inc/collatorImpl.hxx b/i18npool/inc/collatorImpl.hxx
index 34ddfc7..62f1e0a 100644
--- a/i18npool/inc/collatorImpl.hxx
+++ b/i18npool/inc/collatorImpl.hxx
@@ -79,7 +79,7 @@ private:
OUString service;
css::uno::Reference < XCollator > xC;
lookupTableItem(const lang::Locale& rLocale, const OUString& _algorithm, const OUString& _service,
css::uno::Reference < XCollator >& _xC) : aLocale(rLocale), algorithm(_algorithm), service(_service), xC(_xC) {}
css::uno::Reference < XCollator > const & _xC) : aLocale(rLocale), algorithm(_algorithm), service(_service), xC(_xC) {}
bool SAL_CALL equals(const lang::Locale& rLocale, const OUString& _algorithm) {
return aLocale.Language == rLocale.Language &&
aLocale.Country == rLocale.Country &&
diff --git a/package/inc/ZipFile.hxx b/package/inc/ZipFile.hxx
index 021493d..6065a8f 100644
--- a/package/inc/ZipFile.hxx
+++ b/package/inc/ZipFile.hxx
@@ -90,12 +90,12 @@ class ZipFile
public:
ZipFile( const rtl::Reference<comphelper::RefCountedMutex>& aMutexHolder,
css::uno::Reference < css::io::XInputStream > &xInput,
css::uno::Reference < css::io::XInputStream > const &xInput,
const css::uno::Reference < css::uno::XComponentContext > &rxContext,
bool bInitialise );
ZipFile( const rtl::Reference<comphelper::RefCountedMutex>& aMutexHolder,
css::uno::Reference < css::io::XInputStream > &xInput,
css::uno::Reference < css::io::XInputStream > const &xInput,
const css::uno::Reference < css::uno::XComponentContext > &rxContext,
bool bInitialise,
bool bForceRecover );
diff --git a/package/source/zipapi/ZipFile.cxx b/package/source/zipapi/ZipFile.cxx
index 3108578f..11bc362 100644
--- a/package/source/zipapi/ZipFile.cxx
+++ b/package/source/zipapi/ZipFile.cxx
@@ -72,7 +72,7 @@ using ZipUtils::Inflater;
/** This class is used to read entries from a zip file
*/
ZipFile::ZipFile( const rtl::Reference<comphelper::RefCountedMutex>& aMutexHolder,
uno::Reference < XInputStream > &xInput,
uno::Reference < XInputStream > const &xInput,
const uno::Reference < XComponentContext > & rxContext,
bool bInitialise )
: m_aMutexHolder( aMutexHolder )
@@ -93,7 +93,7 @@ ZipFile::ZipFile( const rtl::Reference<comphelper::RefCountedMutex>& aMutexHolde
}
ZipFile::ZipFile( const rtl::Reference< comphelper::RefCountedMutex >& aMutexHolder,
uno::Reference < XInputStream > &xInput,
uno::Reference < XInputStream > const &xInput,
const uno::Reference < XComponentContext > & rxContext,
bool bInitialise, bool bForceRecovery)
: m_aMutexHolder( aMutexHolder )
diff --git a/pyuno/source/module/pyuno.cxx b/pyuno/source/module/pyuno.cxx
index 044eec3..92c58be 100644
--- a/pyuno/source/module/pyuno.cxx
+++ b/pyuno/source/module/pyuno.cxx
@@ -501,7 +501,7 @@ PyObject* PyUNO_dir (PyObject* self)
return member_list;
}
sal_Int32 lcl_detach_getLength( PyUNO *me )
sal_Int32 lcl_detach_getLength( PyUNO const *me )
{
PyThreadDetach antiguard;
@@ -568,7 +568,7 @@ Py_ssize_t PyUNO_len( PyObject* self )
return -1;
}
void lcl_getRowsColumns( PyUNO* me, sal_Int32& nRows, sal_Int32& nColumns )
void lcl_getRowsColumns( PyUNO const * me, sal_Int32& nRows, sal_Int32& nColumns )
{
Sequence<short> aOutParamIndex;
Sequence<Any> aOutParam;
@@ -596,7 +596,7 @@ PyRef lcl_indexToSlice( const PyRef& rIndex )
return rSlice;
}
PyObject* lcl_getitem_XCellRange( PyUNO* me, PyObject* pKey )
PyObject* lcl_getitem_XCellRange( PyUNO const * me, PyObject* pKey )
{
Runtime runtime;
@@ -717,7 +717,7 @@ PyObject* lcl_getitem_XCellRange( PyUNO* me, PyObject* pKey )
return nullptr;
}
PyObject* lcl_getitem_index( PyUNO *me, PyObject *pKey, Runtime& runtime )
PyObject* lcl_getitem_index( PyUNO const *me, PyObject *pKey, Runtime const & runtime )
{
Any aRet;
sal_Int32 nIndex;
@@ -746,7 +746,7 @@ PyObject* lcl_getitem_index( PyUNO *me, PyObject *pKey, Runtime& runtime )
return nullptr;
}
PyObject* lcl_getitem_slice( PyUNO *me, PyObject *pKey )
PyObject* lcl_getitem_slice( PyUNO const *me, PyObject *pKey )
{
Runtime runtime;
@@ -789,7 +789,7 @@ PyObject* lcl_getitem_slice( PyUNO *me, PyObject *pKey )
return nullptr;
}
PyObject* lcl_getitem_string( PyUNO *me, PyObject *pKey, Runtime& runtime )
PyObject* lcl_getitem_string( PyUNO const *me, PyObject *pKey, Runtime const & runtime )
{
OUString sKey = pyString2ustring( pKey );
Any aRet;
@@ -899,7 +899,7 @@ PyObject* PyUNO_getitem( PyObject *self, PyObject *pKey )
return nullptr;
}
int lcl_setitem_index( PyUNO *me, PyObject *pKey, PyObject *pValue )
int lcl_setitem_index( PyUNO const *me, PyObject *pKey, PyObject *pValue )
{
Runtime runtime;
@@ -967,7 +967,7 @@ int lcl_setitem_index( PyUNO *me, PyObject *pKey, PyObject *pValue )
return 1;
}
int lcl_setitem_slice( PyUNO *me, PyObject *pKey, PyObject *pValue )
int lcl_setitem_slice( PyUNO const *me, PyObject *pKey, PyObject *pValue )
{
// XIndexContainer insert/remove/replace by slice
Runtime runtime;
@@ -1085,7 +1085,7 @@ int lcl_setitem_slice( PyUNO *me, PyObject *pKey, PyObject *pValue )
return 1;
}
int lcl_setitem_string( PyUNO *me, PyObject *pKey, PyObject *pValue )
int lcl_setitem_string( PyUNO const *me, PyObject *pKey, PyObject *pValue )
{
Runtime runtime;
diff --git a/pyuno/source/module/pyuno_impl.hxx b/pyuno/source/module/pyuno_impl.hxx
index 3f87ad7..d3f7a6a 100644
--- a/pyuno/source/module/pyuno_impl.hxx
+++ b/pyuno/source/module/pyuno_impl.hxx
@@ -85,14 +85,14 @@ inline char * PyStr_AsString(PyObject *object)
return PyUnicode_AsUTF8(object);
}
inline bool PyStr_Check(PyObject *object)
inline bool PyStr_Check(PyObject const *object)
{
return PyUnicode_Check(object);
}
// compatibility wrappers for Python non-Unicode string/buffer type
// (PyBytes in 3, PyString in 2)
inline bool PyStrBytes_Check(PyObject *object)
inline bool PyStrBytes_Check(PyObject const *object)
{
return PyBytes_Check(object);
}
@@ -162,7 +162,7 @@ static const sal_Int32 CALL = 1;
static const sal_Int32 ARGS = 2;
}
bool isLog( RuntimeCargo *cargo, sal_Int32 loglevel );
bool isLog( RuntimeCargo const *cargo, sal_Int32 loglevel );
void log( RuntimeCargo *cargo, sal_Int32 level, const OUString &logString );
void log( RuntimeCargo *cargo, sal_Int32 level, const char *str );
void logCall( RuntimeCargo *cargo, const char *intro,
diff --git a/pyuno/source/module/pyuno_util.cxx b/pyuno/source/module/pyuno_util.cxx
index aecca4ad2..e92dad2 100644
--- a/pyuno/source/module/pyuno_util.cxx
+++ b/pyuno/source/module/pyuno_util.cxx
@@ -104,7 +104,7 @@ PyRef getObjectFromUnoModule( const Runtime &runtime, const char * func )
// Logging
bool isLog( RuntimeCargo * cargo, sal_Int32 loglevel )
bool isLog( RuntimeCargo const * cargo, sal_Int32 loglevel )
{
return cargo && cargo->logFile && loglevel <= cargo->logLevel;
}
diff --git a/ucb/source/ucp/webdav-neon/NeonSession.cxx b/ucb/source/ucp/webdav-neon/NeonSession.cxx
index ca87d6e..5f9addf 100644
--- a/ucb/source/ucp/webdav-neon/NeonSession.cxx
+++ b/ucb/source/ucp/webdav-neon/NeonSession.cxx
@@ -160,7 +160,7 @@ struct NeonRequestContext
const std::vector< OUString > * pHeaderNames;
DAVResource * pResource;
explicit NeonRequestContext( uno::Reference< io::XOutputStream > & xOutStrm )
explicit NeonRequestContext( uno::Reference< io::XOutputStream > const & xOutStrm )
: xOutputStream( xOutStrm ), xInputStream( nullptr ),
pHeaderNames( nullptr ), pResource( nullptr ) {}
@@ -168,7 +168,7 @@ struct NeonRequestContext
: xOutputStream( nullptr ), xInputStream( xInStrm ),
pHeaderNames( nullptr ), pResource( nullptr ) {}
NeonRequestContext( uno::Reference< io::XOutputStream > & xOutStrm,
NeonRequestContext( uno::Reference< io::XOutputStream > const & xOutStrm,
const std::vector< OUString > & inHeaderNames,
DAVResource & ioResource )
: xOutputStream( xOutStrm ), xInputStream( nullptr ),
