commit d0316985db22efd6708dffa173eaabb430f6b9a8
author Luboš Luňák <l.lunak@collabora.com> Thu Sep 09 16:18:02 2021 +0200
committer Luboš Luňák <l.lunak@collabora.com> Fri Sep 10 10:49:44 2021 +0200
tree fd74bf983ee654b1daa37727687fe2efafbcdb3b
parent e85aaaecb5479660aa0cf600564ee3caa470aa3d

do not intern a temporary cell error string

Interning is way more work than a simple text comparison done once.

Change-Id: If18c478fc62d1fb09ce2141fdb77b46a6bc46c08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121855
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>

sc/source/core/data/table3.cxx

diff --git a/sc/source/core/data/table3.cxx b/sc/source/core/data/table3.cxx
index 97d761f..406284e 100644
--- a/sc/source/core/data/table3.cxx
+++ b/sc/source/core/data/table3.cxx
@@ -2435,8 +2435,8 @@ public:
            if (rCell.meType == CELLTYPE_FORMULA && rCell.mpFormula->GetErrCode() != FormulaError::NONE)
            {
                // Error cell is evaluated as string (for now).
                const svl::SharedString aCellStr = mrStrPool.intern(ScGlobal::GetErrorString(rCell.mpFormula->GetErrCode()));
                return compareByStringComparator(rEntry, rItem, &aCellStr, nullptr);
                const OUString aCellStr = ScGlobal::GetErrorString(rCell.mpFormula->GetErrCode());
                return compareByStringComparator(rEntry, rItem, nullptr, &aCellStr);
            }
            else if (rCell.meType == CELLTYPE_STRING)
            {