commit d3c1a84d4c0bc24defcc497587fa6f258aa8ebdd
author Takeshi Abe <tabe@fixedpoint.jp> Tue Jan 03 05:10:31 2017 +0900
committer Takeshi Abe <tabe@fixedpoint.jp> Wed Jan 04 02:05:24 2017 +0000
tree c728250605b622fa29de11f5f8c52ac07b49679c
parent 9fb55f7b1de8be1c3f86a4ae540f648574d3ed45

starmath: Reenable a test case for SmNodeToTextVisitor

by fixing a regression which seems introduced at
4f294a90877d2f91bb88c7d6cd5b74e8e546a025.

Change-Id: If47f7528f5b5fd04432da134f345d69c25a1ca77
Reviewed-on: https://gerrit.libreoffice.org/32665
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>

starmath/qa/cppunit/test_nodetotextvisitors.cxx

diff --git a/starmath/qa/cppunit/test_nodetotextvisitors.cxx b/starmath/qa/cppunit/test_nodetotextvisitors.cxx
index c3c17f9..e2575c0 100644
--- a/starmath/qa/cppunit/test_nodetotextvisitors.cxx
+++ b/starmath/qa/cppunit/test_nodetotextvisitors.cxx
@@ -228,7 +228,7 @@ void Test::SimpleOperators()
    parseandparseagain("coprod{a}", "Coproduct");
    parseandparseagain("int from {r_0} to {r_t} a", "Upper and lower bounds shown with integral (from & to)");
    ParseAndCheck("int csup {r_0} csub {r_t} a", "int csup { r _ 0 } csub { r _ t } a ", "Upper and lower bounds shown with integral (csub & csup)");
//FIXME    ParseAndCheck("sum csup { size 8 { x - 1 } } csub { size 8 a } b ", "sum csup { size 8 { x - 1 } } csub { size 8 a } b ", "Sum with sized upper and lower bounds");
    ParseAndCheck("sum csup { size 8 { x - 1 } } csub { size 8 a } b ", "sum csup { size 8 { x - 1 } } csub { size 8 a } b ", "Sum with sized upper and lower bounds");
    parseandparseagain("int{a}", "Integral");
    parseandparseagain("intd_{1}^{2}{x dx}", "Dynamically-sized integral");
    parseandparseagain("iint{a}", "Double integral");

starmath/source/visitors.cxx

diff --git a/starmath/source/visitors.cxx b/starmath/source/visitors.cxx
index 90ce467..e6d3935 100644
--- a/starmath/source/visitors.cxx
+++ b/starmath/source/visitors.cxx
@@ -2189,16 +2189,22 @@ void SmNodeToTextVisitor::Visit( SmUnHorNode* pNode )

void SmNodeToTextVisitor::Visit( SmBinHorNode* pNode )
{
    const SmNode *pParent = pNode->GetParent();
    bool bBraceNeeded = pParent && pParent->GetType() == NFONT;
    SmNode *pLeft  = pNode->LeftOperand(),
           *pOper  = pNode->Symbol(),
           *pRight = pNode->RightOperand();
    Separate( );
    if (bBraceNeeded)
        Append( "{ " );
    pLeft->Accept( this );
    Separate( );
    pOper->Accept( this );
    Separate( );
    pRight->Accept( this );
    Separate( );
    if (bBraceNeeded)
        Append( "} " );
}

void SmNodeToTextVisitor::Visit( SmBinVerNode* pNode )