commit d7443d6a3191e37e1e2ad2f2f2d9310e0198b9bf
author Caolán McNamara <caolan.mcnamara@collabora.com> Fri Sep 22 19:59:31 2023 +0100
committer Caolán McNamara <caolan.mcnamara@collabora.com> Mon Sep 25 12:17:20 2023 +0200
tree bca52469a5341c20adb26fe3bab62c5d219d9867
parent 93fa91130cf41ae3cb2f8ef6eb596d34db55c7d1

tdf#157168 GtkSpinButton ignores out-of-range value instead of limiting

(to range)

Change-Id: Ib25276ccea18b45756ac2769cb00cb9d7db0c400
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157124
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>

vcl/unx/gtk3/gtkinst.cxx

diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 5920480..5eb5b15 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -17517,11 +17517,6 @@ public:
        m_aCustomFont.use_custom_font(&rFont, u"spinbutton");
    }

    void set_update_policy_if_valid()
    {
        gtk_spin_button_set_update_policy(m_pButton, GTK_UPDATE_IF_VALID);
    }

    virtual void disable_notify_events() override
    {
        g_signal_handler_block(m_pButton, m_nValueChangedSignalId);
@@ -24351,13 +24346,7 @@ public:

    virtual std::unique_ptr<weld::MetricSpinButton> weld_metric_spin_button(const OUString& id, FieldUnit eUnit) override
    {
        std::unique_ptr<weld::SpinButton> xButton(weld_spin_button(id));
        if (xButton)
        {
            GtkInstanceSpinButton& rButton = dynamic_cast<GtkInstanceSpinButton&>(*xButton);
            rButton.set_update_policy_if_valid();
        }
        return std::make_unique<weld::MetricSpinButton>(std::move(xButton), eUnit);
        return std::make_unique<weld::MetricSpinButton>(weld_spin_button(id), eUnit);
    }

    virtual std::unique_ptr<weld::FormattedSpinButton> weld_formatted_spin_button(const OUString &id) override