commit da7833bf6f8990a8916e3d38090426cb430633a4
author Michael Stahl <michael.stahl@allotropia.de> Fri Aug 12 17:39:18 2022 +0200
committer Caolán McNamara <caolanm@redhat.com> Sun Aug 14 12:57:58 2022 +0200
tree 8630d679829dcfc9d8d769a4e558b6b966239c52
parent 2e1583b59816296e22b080809b2d9a8ef94b49cf

sw: fix crash in InitBookmarks() with forum-mso-en-8410.docx

Error: attempt to dereference a past-the-end iterator.

Probably this only crashes in the assert(iter->pNode...) as the rest of
the function already checks that "iter == end".

(regression from commit 46e04a712e97f9095ef4da7f0e52f50cf2bfbb32)

Change-Id: If652a15d1cdebb21fbce028fceeaee8dce8f7f6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138129
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

sw/source/core/text/porlay.cxx

diff --git a/sw/source/core/text/porlay.cxx b/sw/source/core/text/porlay.cxx
index 8e61614..d91edd8 100644
--- a/sw/source/core/text/porlay.cxx
+++ b/sw/source/core/text/porlay.cxx
@@ -1051,6 +1051,10 @@ static void InitBookmarks(
                break;
            }
        }
        if (iter == end)
        {
            break; // remaining marks are hidden
        }
    }
}