commit dfb42fe42227e99f74d592acb0f27765b4f5e2cf
author Caolán McNamara <caolanm@redhat.com> Wed Apr 01 11:59:51 2020 +0100
committer Caolán McNamara <caolanm@redhat.com> Wed Apr 01 15:09:22 2020 +0200
tree ffb24df9fa9bb7ff5986de7c51381e56a21141a2
parent 5ed29e09f73168a943710837d9877c04d3ee034a

Related: tdf#131613 remove explicit UpdateSettings call

it shouldn't be necessary, if the settings change the windows should
already have been updated without this explicit loop

Change-Id: Id409f17af8be1ad9412be5dfa5bdec63955f6998
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91483
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>

sfx2/source/appl/workwin.cxx

diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx
index 4343b7f..7af0324 100644
--- a/sfx2/source/appl/workwin.cxx
+++ b/sfx2/source/appl/workwin.cxx
@@ -2448,19 +2448,6 @@ void SfxWorkWindow::SetActiveChild_Impl( vcl::Window *pChild )

void SfxWorkWindow::DataChanged_Impl()
{
    sal_uInt16 n;
    sal_uInt16 nCount = aChildWins.size();
    for (n=0; n<nCount; n++)
    {
        SfxChildWin_Impl*pCW = aChildWins[n].get();
        if (pCW && pCW->pWin)
        {
            // TODO does this really have any meaning ?
            if (pCW->pWin->GetWindow())
                pCW->pWin->GetWindow()->UpdateSettings(Application::GetSettings());
        }
    }

    ArrangeChildren_Impl();
}