commit ea6537b455634f785de6482cc01a21a90bcf0ce5
author Mike Kaganski <mike.kaganski@collabora.com> Sun Nov 04 23:01:56 2018 +0300
committer Mike Kaganski <mike.kaganski@collabora.com> Mon Nov 05 08:50:06 2018 +0100
tree af7f2c230537e9e1fff334fe4be5cfc0cfde4d4d
parent 5e45ff5241546ce564eccefcc8b7fff876801415

tdf#120703 PVS: V547 Expression is always true

The inner check looks suspicious. Still, I don't think that intended
behavior was to check nFillDefault, because in that case the next
line would likely start with "else if".

The change just keeps current behavior; I make this an individual
commit to keep the decision's context.

Change-Id: I67d37aa0fee82190ce4bba5784b76c9f522b97ff
Reviewed-on: https://gerrit.libreoffice.org/62864
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

sd/source/filter/eppt/pptexanimations.cxx

diff --git a/sd/source/filter/eppt/pptexanimations.cxx b/sd/source/filter/eppt/pptexanimations.cxx
index 5eabb24..7be6a29 100644
--- a/sd/source/filter/eppt/pptexanimations.cxx
+++ b/sd/source/filter/eppt/pptexanimations.cxx
@@ -282,8 +282,7 @@

    if ( nFill == AnimationFill::DEFAULT )
    {
        if ( nFill != AnimationFill::AUTO )
            nFill = nFillDefault;
        nFill = nFillDefault;
    }
    if( nFill == AnimationFill::AUTO )
    {