| commit | eb07d94074cbc06cea4d938068161bbb25442d0a | [log] |
|---|---|---|
| author | Eike Rathke <erack@redhat.com> | Wed Feb 16 16:56:52 2022 +0100 |
| committer | Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> | Mon Feb 21 15:14:46 2022 +0100 |
| tree | 0ecffb37201d1e77381c8da969f93940f6b56cdd | |
| parent | 8a12c89f8719dc8b46ab5d115ddaf9c8ad43a041 [diff] |
Resolves: tdf#147398 Test Intersects() instead of Contains(), tdf#119083 Regression from commit 8406139062d9ffe1daed32aefe4e261c6c55d63e CommitDate: Mon Dec 6 15:45:35 2021 +0100 process broadcasts for adjacent cells together (tdf#119083) that changed single cell broadcasts to blocks of rows broadcasts and - if (rAreaRange.Contains( rAddress)) + if (rAreaRange.Contains( rRange)) but a block of rows may be distributed over several broadcast areas so rRange is not contained within one rAreaRange and thus was not broadcasted. Testing for intersection instead fixes this. Change-Id: I10700296ebc897e4b7b7752e0e6bcb480085b487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130027 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit a1f21d7094deb6f1ae5388718f2bc28eecd5737a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130013 Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
diff --git a/sc/source/core/data/bcaslot.cxx b/sc/source/core/data/bcaslot.cxx index de77239..d2243ea 100644 --- a/sc/source/core/data/bcaslot.cxx +++ b/sc/source/core/data/bcaslot.cxx
@@ -304,7 +304,7 @@ bool ScBroadcastAreaSlot::AreaBroadcast( const ScHint& rHint) ScBroadcastArea* pArea = (*aIter).mpArea; const ScRange& rAreaRange = pArea->GetRange(); if (rAreaRange.In( rRange)) if (rAreaRange.Intersects( rRange)) { if (pArea->IsGroupListening()) {