commit f4c2c7c79cfe4464ac596afda37b8904d06969db
author Patrick Luby <plubius@neooffice.org> Thu Sep 21 20:20:33 2023 -0400
committer Patrick Luby <plubius@neooffice.org> Fri Sep 22 15:03:43 2023 +0200
tree fc9521145335b5516494485ebf2dc902d518a21a
parent bb3a60cfdbed880e482229e0eed08b5e2e7e311b

tdf#157312 Don't change priority

Instances of this class are constructed with
TaskPriority::POST_PAINT, but then it was set to
TaskPriority::HIGHEST when reused. Flushing
seems to be expensive (at least with Skia/Metal) so keep the
existing priority when reused.

Change-Id: Ieb40cd6122f543f76e66456cc92a8643e2320d73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157162
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@neooffice.org>

vcl/skia/gdiimpl.cxx

diff --git a/vcl/skia/gdiimpl.cxx b/vcl/skia/gdiimpl.cxx
index 3f42546..e4e7179 100644
--- a/vcl/skia/gdiimpl.cxx
+++ b/vcl/skia/gdiimpl.cxx
@@ -268,7 +268,13 @@ public:
    {
        mpGraphics->performFlush();
        Stop();
        SetPriority(TaskPriority::HIGHEST);
        // tdf#157312 Don't change priority
        // Instances of this class are constructed with
        // TaskPriority::POST_PAINT, but then it was set to
        // TaskPriority::HIGHEST when reused. Flushing
        // seems to be expensive (at least with Skia/Metal) so keep the
        // existing priority when reused.
        SetPriority(TaskPriority::POST_PAINT);
    }
};