commit ff643eb3c5b1a50aab5e544ea689e227eecc751d
author Caolán McNamara <caolanm@redhat.com> Mon Oct 15 16:11:57 2018 +0100
committer Caolán McNamara <caolanm@redhat.com> Mon Oct 15 21:01:56 2018 +0200
tree 83bdca440698ddbfd09a757e4961d4d100c42cd8
parent 992ed5bdf9946b59bcd6bfc2250f85e7d0374826

m_pLine is always unset

Change-Id: I269081ed0abcad09b66331d7fc1589e16556bd27
Reviewed-on: https://gerrit.libreoffice.org/61801
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

include/sfx2/basedlgs.hxx

diff --git a/include/sfx2/basedlgs.hxx b/include/sfx2/basedlgs.hxx
index d2ba78b..d427959 100644
--- a/include/sfx2/basedlgs.hxx
+++ b/include/sfx2/basedlgs.hxx
@@ -40,7 +40,6 @@ class OKButton;
class CancelButton;
class HelpButton;
class Button;
class FixedLine;

// class SfxModalDialog --------------------------------------------------

@@ -153,7 +152,6 @@ public:
struct SingleTabDlgImpl
{
    VclPtr<SfxTabPage>          m_pSfxPage;
    VclPtr<FixedLine>           m_pLine;

    SingleTabDlgImpl();
};

sfx2/source/dialog/basedlgs.cxx

diff --git a/sfx2/source/dialog/basedlgs.cxx b/sfx2/source/dialog/basedlgs.cxx
index f8dfdc3..f4a0769 100644
--- a/sfx2/source/dialog/basedlgs.cxx
+++ b/sfx2/source/dialog/basedlgs.cxx
@@ -46,8 +46,7 @@ using namespace ::com::sun::star::uno;
#define USERITEM_NAME "UserItem"

SingleTabDlgImpl::SingleTabDlgImpl()
        : m_pSfxPage(nullptr)
        , m_pLine(nullptr)
    : m_pSfxPage(nullptr)
{
}

@@ -664,7 +663,6 @@ SfxSingleTabDialog::~SfxSingleTabDialog()
void SfxSingleTabDialog::dispose()
{
    pImpl->m_pSfxPage.disposeAndClear();
    pImpl->m_pLine.disposeAndClear();
    pImpl.reset();
    pOKBtn.clear();
    pCancelBtn.clear();