commit f1cb84713664fefd3892671808efe31234e11eec
author Mike Kaganski <mike.kaganski@collabora.com> Thu Jan 30 09:32:18 2020 +0100
committer Adolfo Jayme Barrientos <fitojb@ubuntu.com> Thu Jan 30 23:34:12 2020 +0100
tree b9670450c9e65ab3bad608c15de0b58ac469ebc1
parent 486a99d885e299b5e0b4396bcbf39458b36ac03f

tdf#127566: don't change divcopyable border width in onclick handler

Instead, define border width in respective CSS, to make it consistent
in both clicked and non-clicked states, and avoid "jumping" on click.

Change-Id: Ic8ab8d0fd586059e21de6aa866fef95226774acf
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87718
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
(cherry picked from commit 35281f4c9178f373609a61f0a44e268b179c5749)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87756
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>

help3xsl/default.css

diff --git a/help3xsl/default.css b/help3xsl/default.css
index eeaa160..fe70e42 100644
--- a/help3xsl/default.css
+++ b/help3xsl/default.css
@@ -296,6 +296,7 @@

.pycode,
.bascode {
    border: solid 5px transparent;
    margin-top: 15px;
    margin-bottom: 15px;
}

help3xsl/help.js

diff --git a/help3xsl/help.js b/help3xsl/help.js
index 75541e6..4876722 100644
--- a/help3xsl/help.js
+++ b/help3xsl/help.js
@@ -106,19 +106,17 @@
    (function() {
        var item = itemcopyable[i];

        function changeBorder(item, color, colorToChangeBackTo) {
        function changeBorder(item, color) {
            var saveBorder  = item.style.border;
            item.style.border = "solid 5px";
            item.style.borderColor = color;

            setTimeout(function() {
                item.style.border = saveBorder;
                item.style.borderColor = colorToChangeBackTo;
            }, 150);
        }
        item.onclick = function() {
            document.execCommand("copy");
            changeBorder(item, "#18A303", "transparent");
            changeBorder(item, "#18A303");
        };
        item.addEventListener("copy", function(event) {
            event.preventDefault();