tdf#124235: Make the combo box list be attached to the widget
Don't multiply the offset added to 'top' by the dpi scale factor in
the iOS app.
I see the same problem in Safari on a Retina Mac against normal
online, too, so possibly the multiplication should never be done?
Change-Id: Id63d1d556e8b89612deacf01a734825f1940a5fa
diff --git a/loleaflet/src/control/Control.LokDialog.js b/loleaflet/src/control/Control.LokDialog.js
index 1836bf7..3282b9d 100644
--- a/loleaflet/src/control/Control.LokDialog.js
+++ b/loleaflet/src/control/Control.LokDialog.js
@@ -658,7 +658,17 @@
var dialogTitle = $('.lokdialog_notitle');
if (dialogTitle != null && dialogTitle.length == 0) {
var dialogTitleBar = $('.ui-dialog-titlebar');
top += dialogTitleBar.outerHeight() * L.getDpiScaleFactor();
// tdf#124235: At least in the iOS app, multiplying with
// L.getDpiScaleFactor() below causes the child of a combo box to be
// displaced from the fixed part. I see the same problem also when using
// Safari on a Retuna Mac against normal online. But as I don't know whether
// it happens also for other browsers on other platforms on hidpi displays,
// I will fix this for the iOS app only for now.
if (!window.ThisIsTheiOSApp) {
top += dialogTitleBar.outerHeight() * L.getDpiScaleFactor();
} else {
top += dialogTitleBar.outerHeight();
}
}
floatingCanvas.id = strId + '-floating';